Skip to content

83 updates for rector - #88

Merged
Nealium104 merged 6 commits into
mainfrom
83-updates-for-rector
Sep 9, 2026
Merged

Nealium104 merged 6 commits into
mainfrom
83-updates-for-rector

Conversation

@Nealium104

@Nealium104 Nealium104 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This PR makes some updates to Rector which we use for PHP upgrades and automated code quality scanning.

Changes

  • Updates composer.json to declare its active PHP version. We currently run PHP 8.3 through a docker image. This will make sure we don't break any dependencies by accident.
  • Adds a composer-based set to Rector's options for PHPUnit. Those tests can now be scanned for quality by Rector. If we add more PHP packages, we should check if there are any sets to use.
  • Adds commands for rector invocation to the Makefile. This requires the host to have composer installed. We deliberately exclude from make check because rector can be a bit slow.
  • Updates PHP dependencies

Fixes #88
Fixes #85

@Nealium104
Nealium104 marked this pull request as ready for review September 9, 2026 15:51
@Nealium104
Nealium104 requested a review from a team as a code owner September 9, 2026 15:51

@cokernel cokernel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the core updates, but composer validate reports the following lock file error:

- The lock file is not up to date with the latest changes in composer.json, it is recommended that you run `composer update` or `composer update <package name>`.

I recommend updating composer.lock.

@Nealium104
Nealium104 requested a review from cokernel September 9, 2026 19:26
@Nealium104

Copy link
Copy Markdown
Contributor Author

I am happy with the core updates, but composer validate reports the following lock file error:

- The lock file is not up to date with the latest changes in composer.json, it is recommended that you run `composer update` or `composer update <package name>`.

I recommend updating composer.lock.

Fixed in 761085f

@cokernel cokernel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Nealium104
Nealium104 merged commit f6519c7 into main Sep 9, 2026
3 checks passed
@Nealium104
Nealium104 deleted the 83-updates-for-rector branch September 9, 2026 19:49
This was referenced Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Point rector at current PHP versions

2 participants