Skip to content

Favicon matching exploreuk-web-app #68

Description

@Nealium104

Describe the bug
A clear and concise description of what the bug is.

Favicons in exploreuk-web-app have changed (currently in the limestone-rewrite). Findingaid should also change to match. Here are a few ideas already discussed:

I think we should strip findingaid of all icons, and rely on a hardcoded path to where they will be in production (or a dev environment with the findingaid profile). exploreuk-web-app provides the icons, findingaid relies on those assets existing in prod.
Stripping all references to an icon in findingaid would also fall back to exploreuk-web-app's favicon.
Alternatives would be shipping duplicated assets in findingaid or hosting them on a CDN for both exploreuk-web-app and findingaid.
The only downside to stripping them out entirely on findingaid that I can think of is that if someone adds a findingaid page to the home screen on their phone, they wouldn't get the ExploreUK icon.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions