Some linting improvments to water and vacuum - #4491
Open
je-cook wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4491 +/- ##
==========================================
- Coverage 49.14% 49.12% -0.03%
==========================================
Files 152 152
Lines 29803 29805 +2
==========================================
- Hits 14647 14641 -6
- Misses 15156 15164 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
je-cook
marked this pull request as ready for review
August 10, 2026 13:10
timothy-nunn
left a comment
Collaborator
There was a problem hiding this comment.
Additional refactor that can be done to vacuum:
self.i_vacuum_pumping = self.data.vacuum.i_vacuum_pumping
# i_vacuum_pumping required to be compared to a b string
# as this is what f2py returns- The assigning of
self.i_vacuum_pumpingis unnecessary, its use should be replaced with theself.data.vacuum.i_vacuum_pumping - The comment about "b string" is not correct nor needed since the move to the Python data structure.
clmould
self-requested a review
August 11, 2026 10:42
clmould
requested changes
Aug 11, 2026
| class CoolingWaterBodyCoeffs: | ||
| """Cooling water body coefficients""" | ||
|
|
||
| a: float |
Collaborator
There was a problem hiding this comment.
Could some descriptions be added for these vars please? Or an issue made to do this?
Collaborator
Author
There was a problem hiding this comment.
Issue please I have no idea what they are (they may be different for each case etc)
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes all linting problems on water_use and fixes some on vacuum while trying to avoid changes that #4493 is already aiming to accomplish
Checklist
I confirm that I have completed the following checks: