Skip to content

Some linting improvments to water and vacuum - #4491

Open
je-cook wants to merge 7 commits into
ukaea:mainfrom
je-cook:lint
Open

Some linting improvments to water and vacuum#4491
je-cook wants to merge 7 commits into
ukaea:mainfrom
je-cook:lint

Conversation

@je-cook

@je-cook je-cook commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Description

This fixes all linting problems on water_use and fixes some on vacuum while trying to avoid changes that #4493 is already aiming to accomplish

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.66667% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.12%. Comparing base (b9b6a45) to head (2f33b6f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
process/models/vacuum.py 37.28% 74 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4491      +/-   ##
==========================================
- Coverage   49.14%   49.12%   -0.03%     
==========================================
  Files         152      152              
  Lines       29803    29805       +2     
==========================================
- Hits        14647    14641       -6     
- Misses      15156    15164       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould self-assigned this Aug 3, 2026
@je-cook je-cook changed the title Some linting improvments Some linting improvments to water and vacuum Aug 10, 2026
@je-cook
je-cook marked this pull request as ready for review August 10, 2026 13:10
@je-cook
je-cook requested a review from a team as a code owner August 10, 2026 13:10

@timothy-nunn timothy-nunn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional refactor that can be done to vacuum:

self.i_vacuum_pumping = self.data.vacuum.i_vacuum_pumping

# i_vacuum_pumping required to be compared to a b string
# as this is what f2py returns
  1. The assigning of self.i_vacuum_pumping is unnecessary, its use should be replaced with the self.data.vacuum.i_vacuum_pumping
  2. The comment about "b string" is not correct nor needed since the move to the Python data structure.

@timothy-nunn timothy-nunn assigned timothy-nunn and unassigned clmould Aug 11, 2026
class CoolingWaterBodyCoeffs:
"""Cooling water body coefficients"""

a: float

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could some descriptions be added for these vars please? Or an issue made to do this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue please I have no idea what they are (they may be different for each case etc)

Comment thread process/models/water_use.py Outdated
Comment thread process/models/water_use.py Outdated
Comment thread process/models/vacuum.py
Comment thread process/models/vacuum.py Outdated
Comment thread process/models/vacuum.py
Comment thread process/models/water_use.py Outdated
Comment thread process/models/vacuum.py Outdated
Comment thread process/models/vacuum.py Outdated
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants