Skip to content

4400 remove hardcoded bc20m and tc0m - #4478

Open
chris-ashe wants to merge 11 commits into
mainfrom
4400-remove-hardcoded-bc20m-and-tc0m
Open

4400 remove hardcoded bc20m and tc0m#4478
chris-ashe wants to merge 11 commits into
mainfrom
4400-remove-hardcoded-bc20m-and-tc0m

Conversation

@chris-ashe

Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe linked an issue Jul 27, 2026 that may be closed by this pull request
…them with dynamic properties from SuperconductorModel
@codecov-commenter

codecov-commenter commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.06557% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.13%. Comparing base (6a9a047) to head (8da890b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/models/stellarator/coils/coils.py 4.54% 21 Missing ⚠️
process/models/pfcoil.py 42.85% 8 Missing ⚠️
process/models/tfcoil/superconducting.py 20.00% 8 Missing ⚠️
process/models/superconductors.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4478      +/-   ##
==========================================
- Coverage   49.14%   49.13%   -0.01%     
==========================================
  Files         152      152              
  Lines       29814    29821       +7     
==========================================
+ Hits        14652    14654       +2     
- Misses      15162    15167       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe
chris-ashe requested a review from clmould July 27, 2026 10:09
@chris-ashe
chris-ashe marked this pull request as ready for review July 27, 2026 10:09
@chris-ashe
chris-ashe requested a review from a team as a code owner July 27, 2026 10:09

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things

Comment thread process/models/superconductors.py Outdated
Comment thread process/models/superconductors.py Outdated
Comment thread process/models/stellarator/coils/coils.py Outdated
Comment thread process/models/stellarator/coils/coils.py Outdated
chris-ashe and others added 2 commits July 28, 2026 14:39
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
@chris-ashe
chris-ashe requested a review from clmould July 28, 2026 13:46

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tiny thing

Comment thread process/models/superconductors.py Outdated
@clmould clmould self-assigned this Jul 28, 2026
@chris-ashe
chris-ashe requested a review from clmould August 11, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove hardcoded bc20m and tc0m

3 participants