Skip to content

feat(stovepipe): add Queue.LastGreenRequestID in Stovepipe Queue - #518

Open
roychying wants to merge 1 commit into
mainfrom
chenghan.ying/stovepipe-queue-last-green-request-id
Open

feat(stovepipe): add Queue.LastGreenRequestID in Stovepipe Queue#518
roychying wants to merge 1 commit into
mainfrom
chenghan.ying/stovepipe-queue-last-green-request-id

Conversation

@roychying

Copy link
Copy Markdown
Contributor

Why?

The record stage advances the queue's last-green bookmark, and that bookmark must only ever move forward. entity.Queue today carries LastGreenURI but no record of which request established it, so there is nothing to compare a candidate against — a late-arriving delivery for an older request could regress the bookmark to a stale commit, which process would then hand to build as an incremental baseline.

Adding the owning request id gives the guard something to compare, using the same ingest-order comparison (CompareRequestID) that ingest and process already use for coalescing.

What?

  • entity.Queue gains LastGreenRequestID, paired with the existing LastGreenURI.
  • The MySQL queueStore threads it through Create, Get, and Update.
  • schema/queue.sql gains last_green_request_id VARCHAR(255) NOT NULL DEFAULT '', so existing rows read back as "bookmark never set" and the first green outcome adopts unconditionally.

Test Plan

make gazelle, make build, make test - all clean

Issue

@roychying
roychying requested review from a team, behinddwalls and sbalabanov as code owners August 5, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant