Skip to content

fix: publishing to maven - #963

Merged
shrutiburman merged 4 commits into
mainfrom
gated-release
Aug 26, 2026
Merged

fix: publishing to maven#963
shrutiburman merged 4 commits into
mainfrom
gated-release

Conversation

@shrutiburman

@shrutiburman shrutiburman commented Aug 24, 2026

Copy link
Copy Markdown
Contributor
  • ci.yml — rewritten as a clean unit-test-only workflow.
    Runs on all PRs and pushes.
    Fork PRs use ubuntu-latest with no Artifactory; non-fork uses ubuntu-x64 with Artifactory OIDC.

  • pre-release.yml — new workflow for secrets-heavy operations.
    Runs every Monday 8AM PST + manual dispatch. cluster-test job is behind environment: production with all Twilio credentials. deploy-dry-run runs after, builds the release artifact with GPG skipped — no secrets needed there.

  • test-and-deploy.yml — the publish workflow.
    Triggers on tags + manual dispatch. test job runs unit tests on Java 11/17/21 via Artifactory. deploy job is behind environment: production with required human approval — publishes to Maven Central, creates GitHub release, submits Datadog metric.

Testing gist-
cluster tests run
ci run on this repo
once merged, fork repo test PR- #964

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@kostasniktas kostasniktas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it seems OK to me! Definitely worth trying as an initial go. I got one concrete fix though.

In addition: make sure you're trying to use the latest of all the actions you can find.

The latest hash for the artifactory-oidc is: 4ffc0c647c8d692a8fff24d4f767b207c3d1222e from the main branch. We haven't done an official release in a while. I'll let you know when we do.

Comment on lines +45 to +47
environment:
name: production
url: https://central.sonatype.com/artifact/com.twilio.sdk/twilio/${{ github.ref_name }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block isn't setting an environment variable called name and url. It's telling GitHub to use the environment "production" https://github.com/twilio/twilio-java/settings/environments/19230766429/edit

If you want to add variables to that, you could add them to the environment itself: https://github.com/twilio/twilio-java/settings/environments/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes right. added vars to environment.

Comment thread .github/workflows/test-and-deploy.yml Outdated
strategy:
matrix:
java: [ 8, 11, 17, 21 ]
java: [11, 17, 21]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java 8 is lts, add its support.

@shrutiburman
shrutiburman merged commit 486850a into main Aug 26, 2026
11 of 12 checks passed
@shrutiburman
shrutiburman deleted the gated-release branch August 26, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants