release: write per-platform update manifest fragments with sha256 and size - #241
Closed
rodgolpe wants to merge 2 commits into
Closed
release: write per-platform update manifest fragments with sha256 and size#241rodgolpe wants to merge 2 commits into
rodgolpe wants to merge 2 commits into
Conversation
… size After each OS artifact, hash it, write releases/update-manifest.d/<key>.json, and merge same-version fragments into releases/manifest.json. Packaged package.json honors ONLYKEY_UPDATE_MANIFEST_URL and ONLYKEY_UPDATE_BASE_URL. Does not upload to S3.
Authenticode/notarization changes bytes, so npm run release no longer writes the update manifest. After signing in place, npm run update-manifest hashes that file, refuses NotSigned on Windows/macOS, and reminds the operator to upload the same signed artifact.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After each OS artifact, hash it, write releases/update-manifest.d/.json, and merge same-version fragments into releases/manifest.json. Packaged package.json honors ONLYKEY_UPDATE_MANIFEST_URL and ONLYKEY_UPDATE_BASE_URL. Does not upload to S3.