Link to test collection pages when repo has migrated to test collections - #1156
Closed
TylerJang27 wants to merge 1 commit into
Closed
Link to test collection pages when repo has migrated to test collections#1156TylerJang27 wants to merge 1 commit into
TylerJang27 wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
+ Coverage 82.97% 83.36% +0.39%
==========================================
Files 71 72 +1
Lines 16044 16149 +105
==========================================
+ Hits 13312 13463 +151
+ Misses 2732 2686 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TylerJang27
force-pushed
the
tyler/test-collection-links
branch
2 times, most recently
from
August 13, 2026 20:08
b7c715d to
49c4d3f
Compare
The CLI always emitted legacy repo-scoped test links
(/{org}/flaky-tests/test/{id}?repo=owner/name), which land on the wrong
page for repos that have migrated to test collections. Collection test
pages live at /{org}/flaky-tests/collections/{shortId}/tests/{repoId}_{testId}
and need the repo UUID, which only the server knows.
- createBundleUpload response: add test_collection_migration_state
(repo | test_collection | unspecified, mirroring
quarantine_resolution_mode) and repo_id. The migration state (?? repo)
dictates the link format for the end-of-run test tables; without
repo_id we fall back to the legacy repo-name link. Older servers that
omit both fields keep today's behavior.
- getQuarantineConfig response: add repo_id so the pre-upload failure
log lines (which key off quarantine_resolution_mode) can also link to
the collection page.
- Remove the unused CreateBundleUploadIntentRequest/Response messages.
TylerJang27
force-pushed
the
tyler/test-collection-links
branch
from
August 13, 2026 20:45
49c4d3f to
f7b6e94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CLI always emits legacy repo-scoped test links (
/{org}/flaky-tests/test/{id}?repo=owner/name), which resolve to the wrong page for repos that have migrated to test collections. Collection test pages live at/{org}/flaky-tests/collections/{shortId}/tests/{repoId}_{testId}— a different format that also needs the repo UUID, which only the server knows.What
createBundleUploadresponse gains two optional fields (server change tracked separately):testCollectionMigrationState(repo | test_collection | unspecified) — same server-side calculation asquarantine_resolution_mode.state ?? repodictates which link format the end-of-run test tables use.repoId— the repo UUID the collection URL is keyed by. When the state istest_collectionbutrepoIdis absent, links fall back to the legacy repo-name format.getQuarantineConfigresponse gainsrepoIdso the pre-upload failure log lines (which already key offquarantine_resolution_mode) can link to the collection page too.url_for_test_casetakes an optional collection target;Noneproduces the exact legacy URL as before.CreateBundleUploadIntentRequest/Responsemessages (referenced by nothing).Fully backward compatible: servers that omit the new fields (and dry runs / failed uploads, where no state is available) get today's legacy links unchanged.
Testing
test_collection+repoId→ stderr contains the collection link (/flaky-tests/collections/tc_123/tests/{repo-uuid}_...).test_collectionwithoutrepoId→ falls back to the legacy link, no collection URL emitted.api/cli/test_reportsuites pass.