fix(docker): bind compose Postgres and Redis to loopback - #688
Open
CaptainAni187 wants to merge 1 commit into
Open
fix(docker): bind compose Postgres and Redis to loopback#688CaptainAni187 wants to merge 1 commit into
CaptainAni187 wants to merge 1 commit into
Conversation
Both compose stacks published their datastores on all interfaces, and Redis runs with no password while carrying executor peering. On any shared network that leaves an unauthenticated Redis and a database port reachable from other machines, which contradicts the project's own posture that the standalone stack is for local use. Publish both on 127.0.0.1 in each file, keeping the deliberately different host ports so the two stacks still run side by side. Fixes truefoundry#421
CaptainAni187
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 10, 2026 19:15
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both compose stacks publish Postgres and Redis on all interfaces, and Redis runs with no password. The comment above it notes it carries executor peering, so on a shared network anyone can reach live orchestration traffic unauthenticated and the database port is open too. That also cuts against the project's own posture, where
HOST=defaults to localhost and the standalone stack is documented as local-only.Closes #421
Changes
127.0.0.1indocker-compose.ymlanddocker-compose.dev.ymlLeft Redis auth out deliberately — the issue offers it as an "and/or", and
--requirepasspulls inREDIS_PASSWORDplumbing across.env.exampleand the in-networkREDIS_URL. Loopback binding closes the reachability on its own. Happy to follow up with the password if you want it.How was this tested?
docker compose configon both files, which resolves to:Checklist
format:checkpasses on both files.env.example— not applicableNo changeset, per AGENTS.md: docker-compose changes don't need one. On process: CONTRIBUTING asks for approval first, and all six
help wantedissues are assigned or already have PRs. Close this if you'd rather it went through the queue.