Skip to content

feat(webapp): tab titles that name the page, project and environment - #4517

Open
kathiekiwi wants to merge 7 commits into
mainfrom
feat/page-tab-titles
Open

feat(webapp): tab titles that name the page, project and environment#4517
kathiekiwi wants to merge 7 commits into
mainfrom
feat/page-tab-titles

Conversation

@kathiekiwi

@kathiekiwi kathiekiwi commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Adds a shared pageMeta() helper and 74 route declarations, so a title reads run_abc | Runs | my-project (Prod) | Trigger.dev — the specific thing first, then the page, then the project and environment. Org pages get Team | Acme | Trigger.dev.

Page names are unchanged; the project and environment scope is what's new. Three wording changes on purpose: the queue page now names the queue, the model page names the model, and entity pages carry their section.

A central meta reading each route's handle doesn't work in Remix 2.17 — a meta function only sees the matches up to itself, so root can't read a leaf. That also fixes the existing 49 metas silently dropping root's viewport and robots tags.

@changeset-bot

changeset-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7acd1c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 911b19e4-2406-4b89-ad3c-da5bcc9fe81a

📥 Commits

Reviewing files that changed from the base of the PR and between c20ef4f and 7acd1c4.

📒 Files selected for processing (1)
  • apps/webapp/app/utils/pageTitle.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/webapp/app/utils/pageTitle.test.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout. (16)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
  • GitHub Check: runops-guard / runops-guard
  • GitHub Check: code-quality / code-quality
  • GitHub Check: Analyze (javascript-typescript)

Walkthrough

Added a shared pageMeta utility that composes page, organization, project, environment, and application environment title segments. Updated the root title fallback to use appTitle. Migrated project, organization, account, onboarding, and integration routes to shared metadata declarations. Added dynamic titles for entity routes and page metadata for routes without titles. Added tests for inheritance, scoping, fallbacks, dynamic data, environment labels, and preserved root metadata.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the implementation and rationale but omits the required issue reference, checklist, testing details, changelog, and screenshots sections. Add the required template sections, including the issue reference, completed checklist, testing steps, changelog entry, and screenshots or an explicit statement that none apply.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: browser tab titles now identify the page, project, and environment.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/page-tab-titles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kathiekiwi
kathiekiwi marked this pull request as ready for review August 6, 2026 00:02
@kathiekiwi kathiekiwi changed the title Tab titles that say which page you are on feat(webapp): tab titles that name the page, project and environment Aug 6, 2026
coderabbitai[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant