feat(webapp): storybook gallery for the dashboard agent - #4516
Open
kathiekiwi wants to merge 2 commits into
Open
feat(webapp): storybook gallery for the dashboard agent#4516kathiekiwi wants to merge 2 commits into
kathiekiwi wants to merge 2 commits into
Conversation
The gallery pages for the agent chat, view blocks, report, investigation and watch cards, the demo fixtures behind them, and the screenshot script. This reverts commit bbdcb0881, which held these back out of the parent PR.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdded client-safe dashboard-agent demo fixtures for identifiers, charts, view blocks, investigations, intents, watches, and messages. Added reusable chart and intent components. Replaced the diagnosis-only Storybook route with a gallery framework and routes for agent UI, view blocks, reports, investigations, and watches. Added toast examples, gallery navigation, theme controls, validation tests, and a Playwright screenshot utility with optional chat capture support. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a639bc80-5b35-4a64-b263-9d2283107917
📒 Files selected for processing (24)
apps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/package.jsonapps/webapp/scripts/agent-ui-screenshots.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (14)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: typecheck / typecheck
🧰 Additional context used
📓 Path-based instructions (14)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
**/*.{ts,tsx}: Prefer static imports over dynamicimport(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with//@Crumbsor blocks with `// `#region` `@crumbs, and strip them before merging.
Files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathDo not reintroduce the removed v1 execution path;
RunEngineVersion.V1branches may only reject or finalize gracefully so v3 clients receive a clean 4xx, never a 5xx.
Files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
apps/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For apps, use
typecheckfor verification and never usebuildas the correctness check.
Files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
apps/webapp/app/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/**/*.{ts,tsx}: For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.
UseuseCallbackanduseMemoonly for context provider values, expensive derived data used as a dependency, or stable references required by dependency arrays; do not wrap ordinary event handlers or trivial computations.
Use named constants for sentinel or placeholder values instead of scattering raw string literals across comparisons.
Files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
apps/webapp/app/**/*.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/**/*.ts: Never userequest.signalto detect client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.ts, which is wired to Express response close events.
Access environment variables through theenvexport fromapp/env.server.ts; never useprocess.envdirectly.
Always use PrismafindFirstinstead offindUnique.
Always use the$transactionhelper from~/db.server, never callprisma.$transactionor$replica.$transactiondirectly. Pass isolation levels as strings, useSerializablefor correctness-critical read-then-write invariants, and guard possibly undefined helper results when a definite value is required.
Files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
When adding Zod, use the exact repository-wide pinned version
3.25.76, never a different version or range.
Files:
apps/webapp/package.json
apps/webapp/**/package.json
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
For the webapp, never run
pnpm run build --filter webappto verify changes; usepnpm run typecheck --filter webappafter major changes. Public packages underpackages/*usebuildinstead.
Files:
apps/webapp/package.json
apps/webapp/app/routes/**/*.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/routes/**/*.ts: Use Remix flat-file route conventions with dot-separated segments; for example,api.v1.tasks.$taskId.trigger.tsmaps to/api/v1/tasks/:taskId/trigger.
PAT-authenticated API routes must resolve their target organization or project within the caller's membership scope, using a membership filter or a helper such asfindProjectByReforresolveOrganizationForApiUser; RBAC authorization alone is insufficient.
Files:
apps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/routes/storybook.agent-ui/manifest.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.
Files:
apps/webapp/app/components/dashboard-agent/demo/demo.test.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/app/components/dashboard-agent/demo/demo.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Test files must not import
app/env.server.ts; pass configuration as options instead.
Files:
apps/webapp/app/components/dashboard-agent/demo/demo.test.ts
🧠 Learnings (26)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsxapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/fixtures/index.tsapps/webapp/app/components/dashboard-agent/demo/index.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/intents.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/watches.tsapps/webapp/app/routes/storybook.agent-ui/fixtures.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/chart.tsapps/webapp/app/components/dashboard-agent/demo/demo.test.tsapps/webapp/app/routes/storybook.agent-ui/manifest.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/messages.tsapps/webapp/app/components/dashboard-agent/demo/ids.tsapps/webapp/scripts/agent-ui-screenshots.tsapps/webapp/app/components/dashboard-agent/demo/fixtures/investigation.ts
📚 Learning: 2026-04-27T16:46:03.861Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3456
File: apps/webapp/package.json:152-152
Timestamp: 2026-04-27T16:46:03.861Z
Learning: In `apps/webapp/package.json`, treat the `effect` npm package as an intentional runtime dependency (not unused/misplaced) for the Schedule + Fiber-based metadata update logic. This should apply when reviewing `apps/webapp` code paths used by `apps/webapp/app/utils/updateMetadata.server.ts` (and closely related modules) that use Effect APIs such as `Duration.divide`, `STM.cond`, namespace exports for `Effect`/`Schedule`/`Duration`/`Fiber`, and the `Fiber.RuntimeFiber` type.
Applied to files:
apps/webapp/package.json
📚 Learning: 2026-02-11T16:37:32.429Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3019
File: apps/webapp/app/components/primitives/charts/Card.tsx:26-30
Timestamp: 2026-02-11T16:37:32.429Z
Learning: In projects using react-grid-layout, avoid relying on drag-handle class to imply draggability. Ensure drag-handle elements only affect dragging when the parent grid item is configured draggable in the layout; conditionally apply cursor styles based on the draggable prop. This improves correctness and accessibility.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-07-28T21:57:20.061Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 4411
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.team/route.tsx:818-843
Timestamp: 2026-07-28T21:57:20.061Z
Learning: When using Radix UI `DialogClose` with `asChild` (e.g., Trigger.dev dashboard components), note that it injects `type="button"` into its child via `Slot`. If the child is a local `Button` that forwards its `type` prop to the native `<button>`, then placing it inside a `<form>` will *not* submit unless you explicitly set `type="submit"` (or otherwise override the injected type / wire up submission behavior). Review form actions to ensure the intended submit vs non-submit behavior is preserved.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-04-16T14:21:15.229Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3368
File: apps/webapp/app/components/logs/LogsTaskFilter.tsx:135-163
Timestamp: 2026-04-16T14:21:15.229Z
Learning: When rendering lists of task registry items in apps/webapp (e.g., <SelectItem /> rows) and using `key={item.slug}`, do not flag it as potentially non-unique. In trigger.dev’s `TaskIdentifier` table, the DB constraint `@unique([runtimeEnvironmentId, slug])` guarantees `slug` is unique within a given runtime environment, so `item.slug` is safe as the React key as long as the list is derived from that registry/constraint (and not from a legacy query that could produce duplicate slugs).
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsx
📚 Learning: 2026-05-08T21:00:20.973Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3538
File: apps/webapp/app/components/primitives/Resizable.tsx:60-78
Timestamp: 2026-05-08T21:00:20.973Z
Learning: In the triggerdotdev/trigger.dev codebase, treat Zod as a boundary validation tool (API handlers, request/response validation, and storage/DB read/write validation), not as inline render-time validation inside React components/primitive UI code. For render-time guards, prefer small manual type-narrowing checks (e.g., a short predicate like ~10–20 lines) over importing Zod into UI primitives, to avoid per-render schema-parse overhead and unnecessary abstraction. Use the manual guard approach unless you truly need schema validation at a boundary; only then introduce Zod.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-06-25T18:21:55.847Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-resend.tsx:0-0
Timestamp: 2026-06-25T18:21:55.847Z
Learning: In the triggerdotdev/trigger.dev Zod 4 migration, avoid importing from the root package `conform-to/zod` in webapp code. It can resolve to the Zod 3 build and may crash at module load under Zod 4. When reviewing TypeScript/TSX files in `apps/webapp`, prefer importing from the Zod 4 subpath `conform-to/zod/v4` for Zod 4-compatible schemas/types.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-06-25T18:21:54.729Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/confirm-basic-details.tsx:0-0
Timestamp: 2026-06-25T18:21:54.729Z
Learning: For Remix + TypeScript files that use Conform v1 (conform-to/react) and its getInputProps helper, when you intend to suppress the helper-provided default value for non-checkbox/non-radio inputs (e.g., hidden inputs managed via an explicit value prop), use the Conform v1 option key `value: false`. Do not recommend `defaultValue: false` here, because `defaultValue` is not a valid option key for these input types in Conform v1 typings.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/components/DemoChartCard.tsxapps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsxapps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-02-03T18:27:40.429Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 2994
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx:553-555
Timestamp: 2026-02-03T18:27:40.429Z
Learning: In apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx, the menu buttons (e.g., Edit with PencilSquareIcon) in the TableCellMenu are intentionally icon-only with no text labels as a compact UI pattern. This is a deliberate design choice for this route; preserve the icon-only behavior for consistency in this file.
Applied to files:
apps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-07-22T11:16:06.546Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 4332
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.regions/route.tsx:166-168
Timestamp: 2026-07-22T11:16:06.546Z
Learning: In the Trigger.dev web app, copy-interaction accessibility (keyboard and touch behavior for the copy affordance) is owned by the shared `CopyableText` `icon-right` primitive. When reviewing route-level code (e.g., admin debug panels and runs tables) that intentionally reuses this pattern, avoid suggesting divergent call-site-only accessibility fixes; instead, route any accessibility changes back to a holistic update of the `CopyableText` `icon-right` implementation so all reuse sites benefit consistently.
Applied to files:
apps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-ui/gallery.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-04-02T19:18:26.255Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3319
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions/route.tsx:179-189
Timestamp: 2026-04-02T19:18:26.255Z
Learning: In this repo’s route components that render the Inspector `ResizablePanelGroup` panels, it’s acceptable to pass `collapsed={!isShowingInspector}` together with a no-op `onCollapseChange={() => {}}` when panel visibility is intentionally controlled only by route parameters (e.g., `*Param` search/route params) rather than user drag/collapse interactions. Do not flag an empty/no-op `onCollapseChange` as “missing wiring” in these cases; only flag it when collapse state is expected to change based on user interaction.
Applied to files:
apps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-05-12T21:04:00.184Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.sessions._index/route.tsx:40-42
Timestamp: 2026-05-12T21:04:00.184Z
Learning: In triggerdotdev/trigger.dev route loader implementations (Remix `route.tsx` files under `apps/webapp/app/routes/**`), follow the existing convention for missing/unauthorized environment lookups: when `findEnvironmentBySlug` (or the equivalent env resolver) returns a falsy value, handle it by throwing `new Error("Environment not found")` rather than returning a `404` `Response` (i.e., do not flag this as “missing 404 response”). Changing the error-to-404 convention is a cross-cutting refactor and should be left out of individual PRs unless the PR explicitly addresses that broader migration.
Applied to files:
apps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-05-14T15:57:42.664Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3545
File: apps/webapp/app/routes/storybook.streamdown/route.tsx:1-117
Timestamp: 2026-05-14T15:57:42.664Z
Learning: In triggerdotdev/trigger.dev, `crumbs` markers (e.g., `// crumbs` or `// `#region` crumbs`) are optional debug instrumentation that are stripped before merge, so they are not a hard requirement. During code review, do not flag missing `crumbs` in Storybook/dev-only UI route files—specifically files like `apps/webapp/app/routes/storybook.*/route.tsx`—since there’s nothing in production to trace from these contexts.
Applied to files:
apps/webapp/app/routes/storybook.agent-watch/route.tsxapps/webapp/app/routes/storybook.agent-report/route.tsxapps/webapp/app/routes/storybook.agent-investigation/route.tsxapps/webapp/app/routes/storybook.agent-view-blocks/route.tsxapps/webapp/app/routes/storybook.toast/route.tsxapps/webapp/app/routes/storybook.agent-ui/route.tsx
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/demo.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
apps/webapp/app/components/dashboard-agent/demo/demo.test.ts
Comment on lines
+19
to
+31
| export const demoNavigateToFailedRuns = demoIntent( | ||
| { | ||
| kind: "navigate", | ||
| target: demoRunUri(DEMO_WORLD.failedRunId), | ||
| filters: { | ||
| statuses: ["COMPLETED_WITH_ERROR"], | ||
| period: "24h", | ||
| tasks: [DEMO_WORLD.taskId], | ||
| }, | ||
| }, | ||
| "Opened runs filtered to failed · last 24h · send-order-receipt", | ||
| "/runs?statuses=COMPLETED_WITH_ERROR&period=24h&tasks=send-order-receipt" | ||
| ); |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use the runs collection URI for the filtered-runs intent.
Line 22 sets a run URI, but Lines 29-30 describe opening the filtered runs collection. The equivalent chart action uses demoRunsUri() for that destination. An executor can open the failed run detail instead of the filtered list.
apps/webapp/app/components/dashboard-agent/demo/fixtures/intents.ts#L19-L31: ReplacedemoRunUri(DEMO_WORLD.failedRunId)withdemoRunsUri().apps/webapp/app/components/dashboard-agent/demo/demo.test.ts#L206-L214: Assert thatdemoNavigateToFailedRuns.intent.targetparses as a URI with kind"runs".
Proposed fix
-import { DEMO_WORLD, demoRunUri } from "../ids";
+import { DEMO_WORLD, demoRunUri, demoRunsUri } from "../ids";
...
- target: demoRunUri(DEMO_WORLD.failedRunId),
+ target: demoRunsUri(),📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| export const demoNavigateToFailedRuns = demoIntent( | |
| { | |
| kind: "navigate", | |
| target: demoRunUri(DEMO_WORLD.failedRunId), | |
| filters: { | |
| statuses: ["COMPLETED_WITH_ERROR"], | |
| period: "24h", | |
| tasks: [DEMO_WORLD.taskId], | |
| }, | |
| }, | |
| "Opened runs filtered to failed · last 24h · send-order-receipt", | |
| "/runs?statuses=COMPLETED_WITH_ERROR&period=24h&tasks=send-order-receipt" | |
| ); | |
| export const demoNavigateToFailedRuns = demoIntent( | |
| { | |
| kind: "navigate", | |
| target: demoRunsUri(), | |
| filters: { | |
| statuses: ["COMPLETED_WITH_ERROR"], | |
| period: "24h", | |
| tasks: [DEMO_WORLD.taskId], | |
| }, | |
| }, | |
| "Opened runs filtered to failed · last 24h · send-order-receipt", | |
| "/runs?statuses=COMPLETED_WITH_ERROR&period=24h&tasks=send-order-receipt" | |
| ); |
📍 Affects 2 files
apps/webapp/app/components/dashboard-agent/demo/fixtures/intents.ts#L19-L31(this comment)apps/webapp/app/components/dashboard-agent/demo/demo.test.ts#L206-L214
Comment on lines
+217
to
+229
| for (const { index, title } of rows) { | ||
| // Re-resolve every time: opening a chat leaves the history view and the panel can remount. | ||
| panel = await openPanel(page); | ||
| await showHistory(page, panel); | ||
| await panel.locator("ol > li").nth(index).locator("button").first().click(); | ||
| await page.waitForTimeout(600); | ||
| await freezeMotion(page); | ||
| await capture(panel, { | ||
| theme, | ||
| group: CHAT_GROUP, | ||
| sectionId: slugify(title), | ||
| title, | ||
| }); |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Make each chat screenshot filename unique.
slugify(title) can produce the same value for different chat titles. The later capture then overwrites the earlier PNG. Include index or a durable chat identifier in sectionId.
Proposed fix
- sectionId: slugify(title),
+ sectionId: `${index + 1}-${slugify(title)}`,📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| for (const { index, title } of rows) { | |
| // Re-resolve every time: opening a chat leaves the history view and the panel can remount. | |
| panel = await openPanel(page); | |
| await showHistory(page, panel); | |
| await panel.locator("ol > li").nth(index).locator("button").first().click(); | |
| await page.waitForTimeout(600); | |
| await freezeMotion(page); | |
| await capture(panel, { | |
| theme, | |
| group: CHAT_GROUP, | |
| sectionId: slugify(title), | |
| title, | |
| }); | |
| for (const { index, title } of rows) { | |
| // Re-resolve every time: opening a chat leaves the history view and the panel can remount. | |
| panel = await openPanel(page); | |
| await showHistory(page, panel); | |
| await panel.locator("ol > li").nth(index).locator("button").first().click(); | |
| await page.waitForTimeout(600); | |
| await freezeMotion(page); | |
| await capture(panel, { | |
| theme, | |
| group: CHAT_GROUP, | |
| sectionId: `${index + 1}-${slugify(title)}`, | |
| title, | |
| }); |
kathiekiwi
changed the title
kathiekiwi
marked this pull request as ready for review
August 6, 2026 00:07
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+19
to
+31
| export const demoNavigateToFailedRuns = demoIntent( | ||
| { | ||
| kind: "navigate", | ||
| target: demoRunUri(DEMO_WORLD.failedRunId), | ||
| filters: { | ||
| statuses: ["COMPLETED_WITH_ERROR"], | ||
| period: "24h", | ||
| tasks: [DEMO_WORLD.taskId], | ||
| }, | ||
| }, | ||
| "Opened runs filtered to failed · last 24h · send-order-receipt", | ||
| "/runs?statuses=COMPLETED_WITH_ERROR&period=24h&tasks=send-order-receipt" | ||
| ); |
Contributor
There was a problem hiding this comment.
🟡 Demo example for "open the filtered list of failed runs" actually points at a single run
The demo example that is meant to open the filtered list of failed runs is pointed at one individual run instead (demoRunUri(DEMO_WORLD.failedRunId) at apps/webapp/app/components/dashboard-agent/demo/fixtures/intents.ts:22), so the gallery entry titled "Navigate — runs with filters" describes and displays a destination it does not actually carry.
Impact: Anyone reading the gallery or reusing this example sees a filtered-runs deep link that really points at a single run, so the showcased behaviour is misleading.
Mismatch between the intent target, its stated outcome and its displayed deep link
demoNavigateToFailedRuns sets target: demoRunUri(DEMO_WORLD.failedRunId) while its outcome text says "Opened runs filtered to failed · last 24h · send-order-receipt" and deepLinkLabel is /runs?statuses=.... It is byte-for-byte the same target as demoNavigateToRun (apps/webapp/app/components/dashboard-agent/demo/fixtures/intents.ts:34), so the two fixtures differ only in wording. The runs-list helper demoRunsUri() exists in apps/webapp/app/components/dashboard-agent/demo/ids.ts:25 and is used correctly by the chart fixture (apps/webapp/app/components/dashboard-agent/demo/fixtures/blocks.ts:101). DemoIntentBubble prints intent.intent.target when its button is clicked (apps/webapp/app/components/dashboard-agent/demo/components/DemoIntentBubble.tsx:46-48), so the storybook section intent-navigate-filtered-runs reports a run URI for a state advertised as a filtered runs list. The schema does not catch it because filters is optional on any navigate target (internal-packages/dashboard-agent-contracts/src/intent.ts:9-12), which is why demo.test.ts still passes.
Suggested change
| export const demoNavigateToFailedRuns = demoIntent( | |
| { | |
| kind: "navigate", | |
| target: demoRunUri(DEMO_WORLD.failedRunId), | |
| filters: { | |
| statuses: ["COMPLETED_WITH_ERROR"], | |
| period: "24h", | |
| tasks: [DEMO_WORLD.taskId], | |
| }, | |
| }, | |
| "Opened runs filtered to failed · last 24h · send-order-receipt", | |
| "/runs?statuses=COMPLETED_WITH_ERROR&period=24h&tasks=send-order-receipt" | |
| ); | |
| export const demoNavigateToFailedRuns = demoIntent( | |
| { | |
| kind: "navigate", | |
| target: demoRunsUri(), | |
| filters: { | |
| statuses: ["COMPLETED_WITH_ERROR"], | |
| period: "24h", | |
| tasks: [DEMO_WORLD.taskId], | |
| }, | |
| }, | |
| "Opened runs filtered to failed · last 24h · send-order-receipt", | |
| "/runs?statuses=COMPLETED_WITH_ERROR&period=24h&tasks=send-order-receipt" | |
| ); |
Was this helpful? React with 👍 or 👎 to provide feedback.
Comment on lines
+1
to
+2
| // Keep this file free of imports and JSX: the screenshot script is plain node and | ||
| // cannot import a Remix route module. |
Contributor
There was a problem hiding this comment.
🔍 Manifest and gallery still describe a screenshot script that this PR no longer ships
The manifest's leading comment ("the screenshot script is plain node and cannot import a Remix route module") and the expandText doc ("The screenshot script clicks matching text first") describe tooling that the head commit bfe64cc2 deleted (apps/webapp/scripts/agent-ui-screenshots.ts plus its package.json script), even though the PR description still lists "the screenshot script" as part of this change. The gallery page body repeats it to users: apps/webapp/app/routes/storybook.agent-ui/gallery.tsx:144-145 tells the reader "The list lives in manifest.ts, which the screenshot script walks too", and gallery.tsx:150-151 says the theme buttons are "how the screenshot pack captures both themes". With the script gone, expandText is now dead metadata on GallerySection — nothing in the repo reads it. Either restore the script or drop the references and the unused field.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #4418 so that PR carries only what ships to users.
Adds the agent gallery: five
storybook.agent-*pages (chat UI, view blocks, report, investigation, watch) with their shared shell and manifest, the demo fixtures and two demo-only cards that feed them, the agent toast examples, and the screenshot script.