Harden URL safety checks and sanitization in safe mode (#721) - #722
Open
Crozzers wants to merge 4 commits into
Open
Harden URL safety checks and sanitization in safe mode (#721)#722Crozzers wants to merge 4 commits into
Crozzers wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #721.
First issue was that for HTML encoded colons the semicolon at the end of
:is actually optional, but oursafe_hrefregex didn't account for that. That is now fixed.Second, our auto link checks were accepting URLs like
<http:|>, even in safe mode. This is clearly not a valid URL (I don't even think|is a valid URL char). The_is_auto_linkcheck was modified to check against_safe_hrefin safe mode.Finally, escaped HTML comments weren't having their contents properly sanitized. This is now passed through
_sanitize_htmlto prevent any smuggling