Skip to content

⚡ Bolt: Optimize normalizeTickers array allocations - #151

Closed
toreleon wants to merge 1 commit into
masterfrom
bolt-optimize-normalize-tickers-17338274421530053491
Closed

toreleon wants to merge 1 commit into
masterfrom
bolt-optimize-normalize-tickers-17338274421530053491

Conversation

@toreleon

Copy link
Copy Markdown
Owner

💡 What: Replaced the chained array methods (.map().filter()) inside normalizeTickers with a single for loop that mutates a Set directly.

🎯 Why: The previous implementation created intermediate arrays when chaining .map() and .filter() before passing the result to new Set(). This caused unnecessary memory allocation and garbage collection overhead in a hot path (ticker normalization during discovery).

📊 Impact: Reduces memory allocations and garbage collection pauses by preventing the creation of temporary arrays during ticker processing.

🔬 Measurement: Verify by running the test suite (pnpm test) to ensure functionality is preserved. Additionally, memory profiling during intensive discovery operations should show fewer short-lived array allocations.


PR created automatically by Jules for task 17338274421530053491 started by @toreleon

Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@toreleon

Copy link
Copy Markdown
Owner Author

Closed in favor of #152.

@toreleon toreleon closed this Sep 21, 2026
@toreleon
toreleon deleted the bolt-optimize-normalize-tickers-17338274421530053491 branch September 21, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant