fix: close the DeleteEnvironment check-then-act race on a concurrent CreateSession - #81
Open
AmirF194 wants to merge 1 commit into
Open
Conversation
…CreateSession CountSessionsByEnvironment and DeleteEnvironment ran as two separate repository calls, so a CreateSession landing between them survived a delete that had already decided nothing referenced the environment. Replace both with DeleteEnvironmentUnlessReferenced: pgstore folds the guard into the DELETE's own WHERE NOT EXISTS, memstore holds one lock across the whole check-and-delete. Fixes tokencanopy#80.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80.
Replaced the separate
CountSessionsByEnvironment+DeleteEnvironmentpair with one repository call,DeleteEnvironmentUnlessReferenced, so the check and the write can't be split by a concurrentCreateSession.pgstore folds the check into the
DELETE's ownWHERE ... NOT EXISTS (...). Zero rows affected is ambiguous (already gone vs. still referenced), so it disambiguates with a follow-upGetEnvironment, same shapeSetEnvironmentSnapshotalready uses for stale-vs-not-found. memstore holdsm.muacross the whole check-and-delete instead of two separate lock/unlock pairs.TestDeleteEnvironmentSeesASessionCreatedRightBeforeItsOwnDeleteseeds the racer session from inside the repository's own delete call, the latest point a concurrentCreateSessioncould still land. Reverting just the service-layer hunk (still calling the old two-step path) makes it fail: 204 instead of 409, environment gone despite the live session.go test -race ./controlapp/... ./internal/controld/...passes, including the new test and repotest's E9 case against both memstore and Postgres.go vetand gofmt are clean on the changed files.