Skip to content

net/http: fix nil didTimeout deref when a client dial fails #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deadprogram merged 1 commit into from
Aug 28, 2026
Merged

net/http: fix nil didTimeout deref when a client dial fails #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions http/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,14 @@ func send(req *Request, deadline time.Time) (resp *Response, didTimeout func() b

// TINYGO: Remove TLS error check

return nil, didTimeout, err
// didTimeout must be non-nil whenever err != nil: c.do calls
// didTimeout() on the error path. The named return is nil here (TinyGo
// dropped setRequestCancel), so return alwaysFalse instead to avoid a
// nil func-value dereference on a failed dial.
return nil, alwaysFalse, err
}
if resp == nil {
return nil, didTimeout, fmt.Errorf("http: sendit returned a nil *Response with a nil error")
return nil, alwaysFalse, fmt.Errorf("http: sendit returned a nil *Response with a nil error")
}

// TINYGO: Skip check for resp.Body == nil since we'll set it in roundTrip
Expand Down