chore: upgrade tonic and prost to 0.14 - #552
Conversation
Signed-off-by: Michael Ingley <michael.ingley@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (21)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThis PR updates the tonic/prost toolchain and protobuf generation, adds terminal handling for undetermined and dispatch errors, and removes unnecessary timestamp and region-epoch clones across transaction and lock-resolution paths. ChangesgRPC, retry, and timestamp updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The dependency and generated-client updates pass the listed checks and tests, and no actionable merge-blocking risk remains beyond normal review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Clippy (1.97.1)Clippy execution failed Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Michael Ingley <michael.ingley@gmail.com>
Signed-off-by: Michael Ingley <michael.ingley@gmail.com>
Signed-off-by: Michael Ingley <michael.ingley@gmail.com>
Summary
Copytypes.This advances the dependency alignment described in roadmap issue #506.
Testing Done
make checkcargo test --workspace— 116 passed, 0 failedcargo test --workspace --no-default-features— 116 passed, 0 failedmake doc— passedPD_ADDRS=127.0.0.1:2379 MULTI_REGION=1 RUST_LOG=info NEXTEST_PROFILE=ci cargo nextest run --config-file config/nextest.toml --all --features integration-tests --test-threads 1— 128 passed, 0 failedPD_ADDRS=127.0.0.1:2379 MULTI_REGION=1 RUST_LOG=info NEXTEST_PROFILE=ci cargo nextest run --config-file config/nextest.toml --test failpoint_tests --features 'integration-tests fail/failpoints' --test-threads 1— 6 passed, 0 failedSummary by CodeRabbit