Skip to content

Water layer position on a rough surface #83

Description

@tifuchs

Description

Water layer is currently placed on top of the stack at a fixed position.

If the surface is rough, this produces a sharp scattering contrast, whereas in reality the water would follow the surface profile such as the surface unit cells owned by PoissonSurface.

Possible implementations

  1. Force water model into the PoissonSurface - it would be just another surface unit cell
  2. dynamically place additional unit cells onto the stack in the apply_stacking() function.

The option 2 would be very generic, would require a generic recursive surface / stack building algorithm, that would solve this issue and many other issues, but that would require a major rework.

Option 1 would be the native implementation. Not expandable, which is probably okay for a water model.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    PhysicsIssues related to physicsenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions