chore: remove retired KEEP-era infrastructure tree - #4272
Merged
Conversation
The `./infrastructure/` directory is KEEP-token-era and no longer reflects Threshold Network operations: - Terraform modules source from the now-defunct `thesis/infrastructure` repository on the pre-Threshold `thesis-co` GitHub org. - The `provision-keep-client` initcontainer consumes KEEP contract JSONs (`TokenStaking`, `KeepToken`, `KeepRandomBeacon*`) that were extracted to `threshold-network/keep-core-v1` along with `solidity-v1/`. - GKE manifests deploy into the KEEP `keep-dev-fe24` / `keep-test` GCP projects, not current Threshold infrastructure. - CI already paths-ignored `infrastructure/**` in `.github/workflows/ client.yml`, so the directory was unvalidated. Nothing in `cmd/`, `pkg/`, `tools.go`, or any Dockerfile reads from this tree; removal is safe. Plumbing cleanup that goes with it: - `.gitignore`: drop the `/infrastructure/...` ignore entries. - `.dockerignore`: drop `infrastructure/` from the build context. - `.github/workflows/client.yml`: drop `infrastructure/**` from the push `paths-ignore` and PR `path-filter` (no longer needed). - `docs/dev-ops.adoc`: drop the broken testnet-config link. - `docs/retired-components.md`: replace the `infrastructure/kube/keep-*` bullet with one covering the whole `./infrastructure/` tree so the audit trail is preserved.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…lose live GCP infra Review findings on PR #4272 identified that the bulk infrastructure/ deletion swept up a still-maintained resource and left two disclosure gaps: - infrastructure/kube/keep-test/tbtc-v2-maintainer/ is an actively deployed Kubernetes overlay (kubectl apply -k ./, independent of the retired Terraform) that was bugfixed weeks before this cleanup. Restored at its original path; .dockerignore, .gitignore, and the client workflow's infrastructure/** exclusions are restored to match. - docs/retired-components.md now discloses that keep-test-f3e0 and keep-prd-210b remain live GCP projects (still used by CI and operator docs) managed out-of-band from the removed Terraform, and names the low-sensitivity testnet/dev credential material the removed tree carried.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the entire
./infrastructure/directory (190 files, ~25.9k lines), which is KEEP-token-era infrastructure that no longer reflects Threshold Network operations.Why it's safe to remove
cmd/,pkg/,tools.go, or anyDockerfilereads from./infrastructure/..github/workflows/client.ymlexcludedinfrastructure/**from both the pushpaths-ignoreand the PRpath-filter, so the directory was unvalidated today.git@github.com:thesis/infrastructure.git(pre-Thresholdthesis-coorg, no longer reachable), and theprovision-keep-clientinitcontainer consumes KEEP contract JSONs (TokenStaking.json,KeepToken.json,KeepRandomBeacon*.json) that were extracted tothreshold-network/keep-core-v1along withsolidity-v1/.docs/retired-components.mdalready listsinfrastructure/kube/keep-*as retired KEEP-token dashboard manifests.Plumbing cleanup
.gitignore/infrastructure/...ignore entries and their headers.dockerignoreinfrastructure/from the build context.github/workflows/client.ymlinfrastructure/**from the pushpaths-ignoreand the PRpath-filter(no longer needed)docs/dev-ops.adocdocs/retired-components.mdinfrastructure/kube/keep-*bullet with one covering the whole./infrastructure/tree so the audit trail is preservedVerification
python3 -c "import yaml; yaml.safe_load_all(open('.github/workflows/client.yml'))"→valid YAMLgrep -ri infrastructure/across the repo only matches the intentional audit-trail entry indocs/retired-components.md:15.chore/remove-infrastructure.Out of scope (intentionally not changed)
docs/dev-ops.adocstill describes the GCP + Kubernetes deployment pattern at a high level; the per-environment list of bullets (regional cluster, 10 clients, LoadBalancer, StatefulSet) is left intact as historical context.