P20 mux: further improvements - #11192
Open
piotrhoppeintel wants to merge 1 commit into
Open
Conversation
Use cir_buf_wrap() for writable sink pointers and source_cir_buf_wrap() for read-only source pointers. Mark lookup source pointers as const to avoid discarding qualifiers during circular buffer wrap handling. Signed-off-by: Piotr Hoppe <piotr.hoppe@intel.com>
piotrhoppeintel
force-pushed
the
p20-modules-post-changes
branch
from
September 11, 2026 10:35
3152612 to
fb930d2
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes are const-correct and introduce no unresolved blocking issues.
Pull request overview
Improves const-correctness for mux/demux source buffers and circular-buffer wrapping.
Changes:
- Marks source lookup pointers as
const. - Uses
source_cir_buf_wrap()for read-only sources. - Propagates const source handling through S16/S32 paths.
File summaries
| File | Description |
|---|---|
src/audio/mux/mux.h |
Makes lookup source pointers read-only. |
src/audio/mux/mux_generic.c |
Applies const-safe source wrapping and pointer handling. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PR 11192: test resultsRun date: 2026-09-11 11:21 UTC Tested commit: fb930d228d1ca0ae2d03ad2db50fe37d25b45f39
|
softwarecki
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch writable sink pointers to cir_buf_wrap() and read-only source pointers to source_cir_buf_wrap(). Mark lookup source pointers as const to avoid discarding qualifiers during circular buffer wrap handling.