vmh: fix address categorisation - #11190
Open
lyakh wants to merge 1 commit into
Open
Conversation
VMH doesn't occupy all the available SRAM address space, only a part of it. Use the correct address range to fix the categorisation. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain.
Pull request overview
Corrects VMH address categorization to use the actual configured virtual heap region.
Changes:
- Uses the aligned unused-L2 start as the VMH base.
- Limits categorization to
CONFIG_SOF_ZEPHYR_VIRTUAL_HEAP_REGION_SIZE. - Removes the obsolete linker marker reference.
File summaries
| File | Description |
|---|---|
zephyr/lib/alloc.c |
Updates VMH address-range detection. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kv2019i
approved these changes
Sep 11, 2026
softwarecki
approved these changes
Sep 11, 2026
PR 11190: test resultsRun date: 2026-09-11 15:06 UTC Tested commit: c56d43dd347868a5964a2f2b12ce9d402cb75b8d
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VMH doesn't occupy all the available SRAM address space, only a part of it. Use the correct address range to fix the categorisation.