For tac5272 - #5911
Conversation
|
Can one of the admins verify this patch?
|
|
test this please |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, internally consistent (DAI naming/streams match existing UAJ patterns), and scoped to adding TAC5272 support without impacting other part IDs.
Pull request overview
Adds SoundWire/ASoC support for the TI TAC5272 by introducing a TAC5272-specific codec info entry for SoundWire machine helpers and a matching codec driver registration path in the TAC5xx2 SoundWire codec driver.
Changes:
- Add TAC5272 entry to
codec_info_list[]with a single UAJ (jack) DAI configuration. - Add TAC5272-specific DAI driver definition and component-driver template selection in
tac5xx2-sdw. - Gate SmartAmp/SmartMic SDCA init sequences behind TAC5272 capability flags and add the TAC5272 SDW device ID.
File summaries
| File | Description |
|---|---|
| sound/soc/sdw_utils/soc_sdw_utils.c | Adds TAC5272 codec info entry for UAJ-only SoundWire endpoint/dailink construction. |
| sound/soc/codecs/tac5xx2-sdw.c | Registers TAC5272 as a supported SDW device with a dedicated DAI set and component template, and skips SA/SM init for TAC5272. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| /* UAJ only - no speaker or DMIC */ | ||
| .direction = {true, true}, | ||
| .dai_name = "tac5xx2-aif3", | ||
| .component_name = "tac5272", |
There was a problem hiding this comment.
component_name is currently for the amp only. But it is harmless to add it.
There was a problem hiding this comment.
Thanks, I realized this during the ucm2 file creation.
No description provided.