Conversation
What the core deduces, how a template reads it, and the rules a theme follows: logical properties for what follows the reading direction, explicit variants for graphic choices, and isolation for the values that must not flip. Refs thelia/v2/thelia-2.6#341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Front-Office page documenting right-to-left support, so an integrator building a custom theme inherits the rules rather than reverse-engineering them from Flexy.
What it covers
lang_direction()Twig function and thelang_directionvariable it supersedes, with the fallback spelled out, plus the PHP entry points.rtl:variant, and the note that a centringleft: 50%is not a side.dir="ltr"on a block element re-resolves its owntext-align, and merchant-typed text wants<bdi>rather than a forced direction.What it says is out of scope
PDF invoices and delivery notes, transactional e-mails, translating a theme into a right-to-left language, adding such a language to the default install, and formatting numbers in local digits.
Part of Thelia issue #341. Describes what ships in
thelia/thelia#3972,thelia-modules/TwigEngine#14,thelia-templates/flexy#218andthelia-templates/default-twig#91— worth merging once those are in.