Write the three participation paths once, not twice - #10
Open
snstiago wants to merge 1 commit into
Open
Conversation
Desktop and mobile are separate trees, so this array was written out twice — word for word — from the day Figma Make generated the two files. Nothing had drifted, but only because every copy change was applied to both by hand. It lives in one module now so the next one cannot land on half the site. The array was copied across byte for byte; no string was retyped. It is read in exactly two places, the participate section of each homepage, and nowhere else. Verified against production at 1440 and 390: page height, and the position and width of all three links, are identical. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop and mobile are separate trees, so the
participationPathsarray was written out twice — word for word — from the day Figma Make generated the two files. Nothing had drifted, but only because every copy change was applied to both by hand. It lives in one module now so the next one cannot land on half the site.No pixel moves. The array was copied across byte for byte, no string retyped, and it is read in exactly two places — the participate section of each homepage — and nowhere else.
Verified against production at 1440 and 390:
All three links still point where they did (dashboard, docs, mailto). No new console errors — only the two that were already there.
npm run buildpasses.This leaves 15 phrases still written into both trees; those sit inside the JSX and are a bigger job.
🤖 Generated with Claude Code