fix: add fail-closed v1.21.14 release finalizer - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
GitHub-hosted builders cannot access the private Cargo registry and the Terraphim runner group correctly remains unavailable to public repositories. Build inputs therefore come from the reviewed v1.21.14 source using locked, vendored dependencies; the committed contract binds those inputs to the immutable tag. Signing credentials remain inside GitHub secrets and 1Password. The finalizer runs only from
mainin the repository-scopedtsm-production-releaseenvironment and fails closed before publication.Windows v1.21.14 remains a signed-release manual download: its immutable updater cannot verify ZIP signatures, so Windows is deliberately excluded from stable auto-update manifests. That updater defect requires a subsequent source release.
Validation
1.21.14under native execution or target-container emulation (Windows format validated as PE32+; Wine is unavailable)terraphim-agent learn --help,memory --help, andsessions expand --helppassactionlint, shell syntax checks, andgit diff --checkpassThe existing repository CI build remains red because
cargo fmt --all -- --checkdetects unrelated, pre-existing Rust formatting differences onmain; this PR does not change Rust source.R2 publication remains a separate verified step using
~/my_cloudflare.shafter GitHub asset finalization. No Caddy changes are involved.