fix: disambiguate duplicate Verso labels across Chapter 3 - #657
Open
Chessing234 wants to merge 1 commit into
Open
fix: disambiguate duplicate Verso labels across Chapter 3#657Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Thirty docstrings in Sections 3.1-3.5 shared a label with a sibling declaration, including Exercise 3.1.2, Lemma 3.1.12, Proposition 3.1.17, Axiom 3.6, Exercise 3.1.12, Exercises 3.2.2/3.2.3, Exercises 3.4.5/3.4.10/ 3.4.11 and Definition 3.5.6. Each now names what it covers while keeping the statement number. The stray full stop in "Exercise 3.1.12." goes at the same time, so the three labels match the numbering used everywhere else in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ten groups of sibling declarations in Chapter 3 share a docstring:
Exercise 3.1.2Lemma 3.1.12 (Basic properties of unions) / Exercise 3.1.3Examples 3.1.16Proposition 3.1.17 (Partial ordering by set inclusion)Axiom 3.6 (axiom of specification)Exercise 3.1.12.Exercise 3.2.2,Exercise 3.2.3Exercise 3.4.5,Exercise 3.4.11Exercise 3.4.10Definition 3.5.6Same convention as #624: keep the statement number, name the case in the parenthetical —
(commutativity),(antisymmetry),(complement of a union), and so on. #622 covered Exercises 3.5.4/3.5.5 and #638 Example 3.5.10; these are the remaining collisions in the chapter.One extra:
Exercise 3.1.12.carried a trailing full stop that no other label in the file has, so the three labels now readExercise 3.1.12 (unions)etc. Docstrings only.Checked: no duplicate one-line docstrings remain in any of the four files, all edited lines within 100 characters.
lake buildof all four modules succeeds locally —Build completed successfully (3267 jobs).