fix: disambiguate duplicate Verso labels across Chapter 6 - #656
Open
Chessing234 wants to merge 1 commit into
Open
fix: disambiguate duplicate Verso labels across Chapter 6#656Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Thirteen docstrings in Sections 6.3-6.7 shared a label with a sibling declaration: Definition 6.3.1, Lemma 6.4.13, Lemma 6.5.2, Lemma 6.6.4 and Proposition 6.7.3(e). Each now names the case it covers - sup/inf, limsup/liminf, the three ratio regimes of the geometric limit, reflexivity/transitivity - keeping the statement number intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five groups of sibling declarations in Chapter 6 share a docstring, so Verso cannot tell them apart:
Definition 6.3.1sup,inf)Lemma 6.4.13 (Comparison principle) / Exercise 6.4.4Lemma 6.5.2 / Exercise 6.5.2Lemma 6.6.4 / Exercise 6.6.1Proposition 6.7.3(e) / Exercise 6.7.1Grouped into one PR because each file on its own is two to four lines; #633/#637/#604 already covered the example and exercise labels in this chapter, these are the remaining statement labels. Same convention as #624: keep the statement number, name the case in the parenthetical. Docstrings only.
Checked: no duplicate one-line docstrings remain in any of the five files, all edited lines within 100 characters.
lake buildof all five modules succeeds locally —Build completed successfully (3279 jobs).