fix: disambiguate duplicate Verso labels in Section 4.1 - #653
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Seventeen docstrings across six groups shared a label: Definition 4.1.1, Lemma 4.1.3, Proposition 4.1.6, Definition 4.1.10, Lemma 4.1.11(d) and Lemma 4.1.11(f). The part goes in the parenthetical, matching Section 4.2 and Proposition 9.3.14. The `Definition 4.1.1` on the `PreInt` setoid instance is left alone: it is the only one without the `(Integers)` qualifier, so it does not collide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 4.1 has six groups of declarations sharing one docstring:
Definition 4.1.1 (Integers)— 2Lemma 4.1.3 (Multiplication well-defined)— 3Proposition 4.1.6 (laws of algebra) / Exercise 4.1.4— 4 instancesDefinition 4.1.10 (Ordering of the integers)— 2 instancesLemma 4.1.11(d) (Negation reverses order) / Exercise 4.1.7— 2Lemma 4.1.11(f) (Order trichotomy) / Exercise 4.1.7— 4Same convention as #624 and the companion Section 4.2 PR: keep the statement name, fold the part into the parenthetical. Docstrings only.
One deliberate non-change: the bare
Definition 4.1.1on thePreIntsetoid instance keeps its label, since it is the only one without the(Integers)qualifier and so does not collide.Checked: no duplicate one-line docstrings remain, all edited lines within 100 characters.
lake build Analysis.Section_4_1succeeds locally —✔ [3265/3265] Built Analysis.Section_4_1 (163s),Build completed successfully.