[SDK Sentinel] Avoid worker deployment routing propagation flake - #553
Closed
sdk-sentinel-bot wants to merge 1 commit into
Conversation
Member
|
Unsure what this one is about, but it is referencing a PR branch failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
Prevents the worker-deployment versioning test from failing when routing propagation takes longer than the shared 10-second polling budget. A [macOS Ruby 3.3 job](https://github.com/temporalio/sdk-ruby/actions/runs/32416404833/job/96578433616) observed an in-progress state, while peer jobs on the same SHA completed. See the [last known good run](https://github.com/temporalio/sdk-ruby/actions/runs/32396288823) and [first observed failure](https://github.com/temporalio/sdk-ruby/actions/runs/32416404833).
Root cause
Routing configuration propagation is asynchronous. The test treated a legitimate in-progress state after 10 seconds as a failure, making it sensitive to server scheduling latency.
Fix
Use a call-specific 30-second bound for routing propagation. The existing 200ms polling and terminal-state assertions remain unchanged.
Validation
Five unchanged local attempts did not reproduce the failure, and five patched attempts passed. Focused RuboCop, syntax, and diff checks passed. The unchanged baseline passed. Canonical candidate validation could not start because Rust was unavailable; the macOS Ruby 3.3 job and canonical validation remain required.
Validation status:
validation-incompletehighmediummediumstandard— 1 changed file; 776 Bnot-reproduced— Five unchanged direct Linux executions passed; the standard Rake entry point was unavailable because Rust was absent.pass-after-only— The existing focused test passed five times after the change; no deterministic pre-change failure was obtained.RuboCop, Steep, Rust lint, and native compile) — passedRuboCop, Steep, Rust lint, and native compile) — did not pass (failure)Investigator-run checks
bundle exec ruby -Itest -Ilib test/worker_workflow_versioning_test.rb --name=test_worker_deployment_version— passed; 5 attempt(s). Five unchanged Linux executions passed; the CI timing failure did not reproduce.bundle exec ruby -Itest -Ilib test/worker_workflow_versioning_test.rb --name=test_worker_deployment_version— passed; 5 attempt(s). Five candidate executions passed against loopback Temporal servers..ci-flake-runtime/input/validate.sh (trusted unchanged baseline)— passed; 1 attempt(s). The trusted pre-change baseline passed..ci-flake-runtime/input/validate.sh— failed; 1 attempt(s). Candidate validation stopped during Rake initialization because rustup had no installed/default toolchain.bundle exec rubocop test/worker_workflow_versioning_test.rb && ruby -c test/worker_workflow_versioning_test.rb && git diff --check— passed; 1 attempt(s). Focused lint, syntax, and whitespace checks passed.Required target CI
Residual risks
Automation provenance
ad5eb22f0956810afeb7dad67746c6afceecb9fcIf this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-08-20 21:13 UTC2026-08-20 21:13 UTC