Add Nexus SAA sample - #214
Merged
Merged
Conversation
atol
marked this pull request as ready for review
August 21, 2026 18:01
| [NexusServiceHandler(typeof(IGreetingService))] | ||
| public class GreetingService | ||
| { | ||
| [NexusOperationHandler] |
Contributor
There was a problem hiding this comment.
We can simplify this a lot by using TemporalOperation. Removes the whole TemporalOperationHandler.FromHandleFactory
Contributor
Author
There was a problem hiding this comment.
Thanks! Updated to use TemporalOperation.
jmaeagle99
reviewed
Aug 28, 2026
jmaeagle99
left a comment
jmaeagle99
left a comment
Contributor
There was a problem hiding this comment.
Other than the following comment and the feedback in https://github.com/temporalio/samples-dotnet/pull/214/changes#r3846380545, I think this sample looks good.
|
|
||
| using NexusRpc; | ||
|
|
||
| // Nexus service definition shared by the caller and the handler. It declares a single operation |
Contributor
There was a problem hiding this comment.
nit: I don't think the interface should document what backs the operation implementation and should be moved to said operation implementation, namely the GreetingService.
jmaeagle99
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds a sample demonstrating using
TemporalOperationHandlerto start a standalone Activity.