test(e2e): tick objects before History revert execute - #272
Merged
Conversation
Zero ticks is refused after #263 (not whole-schema). The happy-path revert suite still called Execute with an empty tree, so the button stayed disabled. Select all, same as the lossy edge cases. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
huyplb
marked this pull request as ready for review
August 18, 2026 05:53
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_b9d15000-5959-4620-8330-d622a26c18c8) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran History/revert e2e against 0.2.105 (
http://127.0.0.1:5173).Results
schema-history.test.ts— 6/6schema-version-revert-edges.test.ts— 10/10schema-revert.test.ts— 2 failed, then 4/4 after this fixFailure
After #263, Execute stays disabled until objects are ticked. The happy-path revert suite still called
executeRevert()on an empty tree (waitForFunction30s, then the follow-up could not find Compare versions).Fix
Call
selectAllCompareObjects()before Execute in both apply tests — same as the lossy edge cases.Not run: dialect Docker e2e (Docker is not in this environment).