Fix singleton class external token name typo - #6
Merged
Conversation
The hidden external token for the `<<` in `class << self` was named `_singleton_class_left_angle_left_langle`, duplicating "l" from "langle" onto an already spelled-out "left_angle". The scanner's matching enum is `SINGLETON_CLASS_LEFT_ANGLE_LEFT_ANGLE`; line the grammar name up with it so the external token list reads the same on both sides. The token stays hidden and aliased to `<<`, so no public node name changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hidden external token for the
<<inclass << selfwas named_singleton_class_left_angle_left_langle, which duplicates the "l" from "langle" onto an already spelled-out "left_angle". The scanner's matching enum isSINGLETON_CLASS_LEFT_ANGLE_LEFT_ANGLE, so the two sides of the external token list did not read the same.The token stays hidden and aliased to
<<, so no public node name changes andsrc/node-types.jsonis unaffected.Validation
grammar.js;src/grammar.jsonandsrc/parser.cchange only where the regenerated parser embeds the symbol name.References
Reimplements tree-sitter#296.
Note: this branch and #11 both regenerate
src/parser.c, so whichever merges second will need a regenerate.