refactor(evidence): remove dead scoring and canonicalize paths - #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unused
RunCriticinferred test quality from command text and treated URLs as task drift.Its adapter was already removed, and no package entry or production module imports it.
Delete the critic, its three tests, and its stale comment reference.
Keep the public scoring types and the steering optimizer.
Validation exposed an artifact-root mismatch through symbolic links.
Use one canonical root for artifact reads and relative manifest paths.
Add a regression that compares direct and linked roots.
Make the artifact-swap fixture use canonical paths, and let the output fixture drain stderr before exiting.
The worktree adapter also returned paths that its own finalization check rejected through symbolic-link parents.
Return the canonical path of each created checkout so finalization and cleanup use Git's directory identity.
Preserve rejection of substituted worktree locators.
Exercise creation, finalization, verification, and cleanup through linked repository and worktree roots.
Validation on
fa167c37817786d3ddfa643804529ce4b026e5c4:CI run