fix(supervisor-run): reject invalid Runtime tree ownership - #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Runtime strict reader accepted two malformed ownership shapes: one spawn could own both its explicit owned-tree path and its legacy child-id path, and a descendant spawn could be written in the parent tree instead of the tree its parent owns.
This change makes an explicit ownedTreeRoot exclusive, validates each descendant spawn against the tree owned by its parent, and keeps legacy child-id roots only when no explicit owned root exists. Two public-reader regression tests reproduce both false positives.
Checks: