Skip to content

fix(supervisor-run): follow Runtime-owned tree roots - #735

Merged
drewstone merged 2 commits into
mainfrom
fix/runtime-owned-tree-root
Sep 4, 2026
Merged

fix(supervisor-run): follow Runtime-owned tree roots#735
drewstone merged 2 commits into
mainfrom
fix/runtime-owned-tree-root

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

Summary

  • Resolve nested Runtime journals through spawned.ownedTreeRoot when the tree path differs from the child id.
  • Preserve child-id journals with one duplicate self-spawn marker and verify profile identity across both records.
  • Reject duplicate parent ownership, retain independent-root rejection, and classify the spawned child id as supervisor.
  • Release the fix as npm and PyPI version 0.173.2.

Root cause

The reader matched every nested begin.root only against spawned.id. Runtime records canonical nested roots as ownership paths, so valid child trees appeared to be independent top-level runs.

Verification

  • pnpm exec vitest run src/supervisor-run/runtime-reader.test.ts — 16 passed.
  • pnpm typecheck — passed.
  • pnpm lint — 743 files passed.
  • pnpm build — passed.
  • pnpm verify:package — passed.
  • Built local 0.173.2 read the retained scientific-oscillator journal with strict: true: 24 normalized rows, 4 child invocations, 2 nested supervisors, and 2 leaf workers.

Local full-suite note

pnpm test completed 5,705 of 5,747 tests locally. Thirty-seven unrelated failures come from the macOS /var to /private/var path alias in temporary-path checks. Two unrelated process-output tests also failed locally. The same base commit passes the full Linux CI workflow: https://github.com/tangle-network/agent-eval/actions/runs/33772469065.

Runtime nested begin roots can be ownership paths instead of child ids. Resolve each nested tree through exactly one parent spawn and retain child ids for supervisor identity.
@drewstone
drewstone merged commit f22750d into main Sep 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant