Skip to content

fix(deps): resolve open Dependabot alerts - #734

Merged
drewstone merged 2 commits into
mainfrom
fix/dependabot-alerts-20260903
Sep 3, 2026
Merged

fix(deps): resolve open Dependabot alerts#734
drewstone merged 2 commits into
mainfrom
fix/dependabot-alerts-20260903

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

Summary

Resolves both open Dependabot alerts (SOC 2 Vanta Request 7).

Alert Package Severity From To
#53 npm:fast-uri high 3.1.5 (>= 3.1.3, < 3.1.6) 3.1.6
#54 npm:fast-uri high 3.1.5 (>= 3.1.2, < 3.1.6) 3.1.6

Both alerts are the same transitive dependency (via ajv), pinned through the existing pnpm.overrides entry in package.json. Bumping the override to 3.1.6 (the first patched version for both advisories) resolves both. pnpm-lock.yaml now resolves a single fast-uri@3.1.6 everywhere (verified via grep — no other versions present).

Bumping pnpm-lock.yaml invalidated the pinned dependency-lock digest that pnpm run verify:package checks (src/analyst/benchmark-implementation.ts, regenerated via pnpm analyst:pin). That's the only other file this PR touches.

No other manifest is affected: clients/python/pyproject.toml / uv.lock have no open alerts.

Gate results (run locally, NODE_OPTIONS=--no-network-family-autoselection for this host's IPv6-less network)

Gate Command Result
Install pnpm install --frozen-lockfile pass
Build pnpm build pass
Typecheck pnpm typecheck pass
Typecheck examples pnpm typecheck:examples pass
Typecheck scripts pnpm typecheck:scripts pass
Lint pnpm lint (biome) pass — 743 files, no fixes needed
Model-id gate pnpm run check:model-ids pass
Finding contract pnpm run contract:finding:check pass
Package verify pnpm run verify:package pass (after pnpm analyst:pin)
Test pnpm test 39 failed / 5703 passed / 3 skipped — see below
Python sync uv sync --frozen --extra dev (in clients/python) pass
Python tests uv run --frozen --extra dev pytest -v (base extras only) 190 passed, 16 failed — all ModuleNotFoundError: skillopt/gepa, from optional skillopt-source/gepa-source groups not installed in this scoped run; unrelated to this diff

pnpm test failures are pre-existing, not caused by this change

Verified by cloning the pre-WIP commit (3c11a598, i.e. main before this branch) into a clean worktree and running the same suite: identical 39 failures, same files, same counts. Root cause for the largest cluster (tests/campaign/worktree.test.ts, 27/29 failing) is macOS-specific: /tmp resolves through a symlink (/private/tmp) on this host, which trips the suite's symlink-escape detection in src/campaign/worktree/index.ts. CI (.github/workflows/ci.yml) runs on ubuntu-latest, where /tmp is not a symlink, so this cluster is not expected to reproduce there. The remaining 11 failures (src/analyst/benchmark-command*.test.ts, benchmark-implementation.test.ts, benchmark-verification-artifacts.test.ts, external-optimizer-process.test.ts) reproduce identically on baseline and are unrelated to the dependency bump.

No tests were modified, skipped, or weakened to reach this result.

Alerts left

None — both open alerts addressed.

Alerts #53 and #54 flag fast-uri below 3.1.6, both high severity.
Commit 902873c already bumped fast-uri to 3.1.6 in package.json and
pnpm-lock.yaml.

This commit regenerates the pinned analyst-benchmark dependency-lock
digest with `pnpm analyst:pin`. The digest pins pnpm-lock.yaml content
and went stale after the bump, failing `pnpm run verify:package`.
@drewstone
drewstone merged commit 4712c50 into main Sep 3, 2026
2 checks passed
@drewstone
drewstone deleted the fix/dependabot-alerts-20260903 branch September 3, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant