Version Packages - #543
Open
github-actions[bot] wants to merge 1 commit into
Open
Version Packages#543github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@tailor-platform/app-shell@1.15.1
Patch Changes
48f9f90: Rebuild the
form/composerpattern onForm+Field. It was the onlyform/*pattern with neither — a bareCardof controls with anonClicksubmit — which left it inconsistent with its four siblings and short of three things a composer actually needs.The body now sits in a
Field.Rootwith asr-onlyField.Label(a real label instead ofaria-label, so error and description wiring stays available), Send istype="submit"so validation gates it, and server rejections — moderation, rate limit, thread closed — route throughForm'serrorsprop intoField.Errorrather than a toast, landing next to the text the user still has.The body stays controlled: it is read during render to gate Send and to swap the placeholder, which a submit-time handler cannot do. The pattern doc now says so explicitly, because this is the one
form/*pattern where field state is load-bearing rather than redundant — elsewhereonFormSubmitreads registeredField.Roots and mirroring values into state is the anti-pattern.Also fixes a data-loss path in the reference implementation: it cleared the body unconditionally, losing the user's text when a submit failed. It now clears only on success.