refactor(core): align state ownership with React Compiler by IzumiSy · Pull Request #525 · tailor-platform/app-shell

IzumiSy · 2026-09-11T06:30:05Z

Motivation

Update the repository's pinned oxlint version to 1.82.0 while keeping every configured lint rule enabled. Align the affected React components and hooks with React Compiler-compatible state, effect, and ref usage.

Design Decision

Make reactive state explicit

Values that influence rendering or represent pending work are modeled as props or React state, rather than being read from mutable refs during render. User interactions update that state at their source; components then derive their UI from the current render. This gives React Compiler a clear data flow and makes update ordering easier to reason about.

Limit refs and effects to imperative boundaries

Refs remain for resources React does not own directly: DOM nodes, timers, abort controllers, observer handles, and similar imperative integration state. Effects are retained only where they synchronize with those external resources or perform their cleanup, rather than mirroring state or notifying callbacks after the fact.

Preserve public behavior during local migrations

Each change is scoped to the smallest owner of the behavior, retaining existing component contracts and interaction semantics. Tests exercise the resulting behavior directly—using renderHook for hook state where appropriate—rather than relying on effect-populated test snapshots. The DataTable selection addition is the only intentional public API expansion.

Keep the lint configuration authoritative

The upgrade is addressed by changing implementation ownership, not by disabling rules, adding suppressions, or weakening the lint configuration. This leaves the codebase with one consistent direction for future components and hooks.

Summary

Pin oxlint 1.82.0 and resolve all resulting lint errors without suppressions or lint configuration changes.
Define ownership boundaries for async loading, action registration, attachments, responsive subscriptions, DataTable state, and date controls.
Add controlled and uncontrolled DataTable row selection support with a minor changeset.

IzumiSy · 2026-09-11T07:02:23Z

@copilot resolve the merge conflicts in this pull request

…er-state-ownership # Conflicts: # packages/core/src/components/data-table/data-table.test.tsx Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

IzumiSy · 2026-09-11T07:13:00Z

@copilot fix CI error

Copilot · 2026-09-11T07:13:03Z

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in 685b465.

Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot · 2026-09-11T07:16:19Z

@copilot fix CI error

Fixed and pushed in 3dacba2.

github-actions · 2026-09-11T07:27:43Z

Code Metrics Report

	main (6b0e0d6)	#525 (636fa81)	+/-
Coverage	87.2%	87.1%	-0.1%
Test Execution Time	2m5s	1m56s	-9s

Details

  |                     | main (6b0e0d6) | #525 (636fa81) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          87.2% |          87.1% | -0.1% |
  |   Files             |            198 |            198 |     0 |
  |   Lines             |           5840 |           5876 |   +36 |
+ |   Covered           |           5093 |           5123 |   +30 |
+ | Test Execution Time |           2m5s |          1m56s |   -9s |

Code coverage of files in pull request scope (85.4% → 85.3%, patch 94.3%)

Files	Coverage	+/-	Patch Coverage	Status
packages/core/src/ai/use-ai-chat.ts	90.6%	0.0%	95.5%	modified
packages/core/src/components/ai-chat/composer.tsx	100.0%	0.0%	-	modified
packages/core/src/components/attachment/use-attachment.ts	100.0%	0.0%	100.0%	modified
packages/core/src/components/csv-importer/CsvImporter.tsx	0.5%	0.0%	0.0%	modified
packages/core/src/components/csv-importer/i18n-labels.ts	100.0%	0.0%	-	modified
packages/core/src/components/data-table/data-table.tsx	90.9%	+0.0%	100.0%	modified
packages/core/src/components/data-table/index.ts	0.0%	0.0%	-	modified
packages/core/src/components/data-table/use-data-table.ts	98.8%	+0.0%	100.0%	modified
packages/core/src/components/data-table/use-persistent-column-state.ts	94.5%	-5.5%	91.4%	modified
packages/core/src/components/date-field/date-field.tsx	100.0%	0.0%	100.0%	modified
packages/core/src/components/date-field/date-input-group.tsx	81.5%	0.0%	-	modified
packages/core/src/components/date-field/date-range-input-group.tsx	100.0%	0.0%	-	modified
packages/core/src/components/date-field/date-range-picker.tsx	97.7%	+0.0%	100.0%	modified
packages/core/src/components/date-field/use-date-field-bridge.ts	93.9%	-0.5%	91.3%	modified
packages/core/src/components/description-card/field-renderers.tsx	83.9%	-0.2%	50.0%	modified
packages/core/src/components/select/select-standalone.tsx	95.5%	-0.3%	100.0%	modified
packages/core/src/components/sidebar/default-sidebar.tsx	97.5%	0.0%	-	modified
packages/core/src/components/sidebar/sidebar-item.tsx	95.4%	0.0%	-	modified
packages/core/src/components/timeline/timeline.tsx	98.6%	0.0%	100.0%	modified
packages/core/src/contexts/auth-context.tsx	95.7%	0.0%	-	modified
packages/core/src/contexts/command-palette-context.tsx	98.3%	+0.2%	100.0%	modified
packages/core/src/hooks/use-async-items.ts	100.0%	0.0%	100.0%	modified
packages/core/src/hooks/use-mobile.ts	87.5%	-2.5%	85.7%	modified
packages/core/src/hooks/use-tablet.ts	88.8%	-2.1%	85.7%	modified
packages/core/src/index.ts	0.0%	0.0%	-	modified
packages/core/tests/rhf-test-utils.tsx	72.7%	-16.2%	40.0%	modified

Reported by octocov

Copilot

🟡 Changes recommended

Controlled expansion callbacks regress their stability contract, while column measurement, storage fallback, and the new public type export remain incomplete.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Aligns React state ownership with React Compiler requirements, upgrades oxlint, and expands DataTable row selection.

Changes:

Refactors effects, refs, callbacks, and external-store subscriptions.
Adds controlled/uncontrolled DataTable selection.
Updates accessibility, tests, examples, and release metadata.

File summaries

File	Description
`pnpm-workspace.yaml`	Pins oxlint 1.82.0.
`pnpm-lock.yaml`	Updates resolved dependencies.
`packages/core/tests/rhf-test-utils.tsx`	Uses a hook harness for RHF.
`packages/core/src/hooks/use-tablet.ts`	Uses external-store media subscriptions.
`packages/core/src/hooks/use-override-breadcrumb.test.tsx`	Refactors hook testing.
`packages/core/src/hooks/use-mobile.ts`	Uses external-store media subscriptions.
`packages/core/src/hooks/use-async-items.ts`	Refactors async request ownership.
`packages/core/src/contexts/theme-context.test.tsx`	Tests context through `renderHook`.
`packages/core/src/contexts/scroll-container-context.test.tsx`	Refactors scroll-context tests.
`packages/core/src/contexts/command-palette-context.tsx`	Separates action registration and updates.
`packages/core/src/contexts/auth-context.tsx`	Corrects effect dependencies.
`packages/core/src/contexts/auth-context.test.tsx`	Consolidates authentication test helpers.
`packages/core/src/components/with-guard/with-guard.test.tsx`	Hoists stable test guards.
`packages/core/src/components/tooltip/tooltip.test.tsx`	Adds an accessible trigger name.
`packages/core/src/components/timeline/timeline.tsx`	Uses non-mutating sorting.
`packages/core/src/components/sidebar/sidebar.test.tsx`	Hoists viewport mocking.
`packages/core/src/components/sidebar/sidebar-layout.test.tsx`	Corrects desktop test width.
`packages/core/src/components/sidebar/sidebar-item.tsx`	Labels external links.
`packages/core/src/components/sidebar/default-sidebar.tsx`	Labels the search trigger.
`packages/core/src/components/select/select-standalone.tsx`	Uses current async callbacks directly.
`packages/core/src/components/description-card/field-renderers.tsx`	Refines copy and truncation behavior.
`packages/core/src/components/date-field/use-date-field-bridge.ts`	Refactors form-validation bridging.
`packages/core/src/components/date-field/date-range-picker.tsx`	Refactors combined range state handling.
`packages/core/src/components/date-field/date-range-picker.test.tsx`	Hoists a calendar test helper.
`packages/core/src/components/date-field/date-range-input-group.tsx`	Uses capture-phase focus events.
`packages/core/src/components/date-field/date-input-group.tsx`	Uses capture-phase focus events.
`packages/core/src/components/date-field/date-field.tsx`	Refactors state and forwarded refs.
`packages/core/src/components/date-field/date-field.test.tsx`	Hoists shared test helpers.
`packages/core/src/components/data-table/use-persistent-column-state.ts`	Adds cached external-store persistence.
`packages/core/src/components/data-table/use-data-table.ts`	Adds row-selection ownership and stores.
`packages/core/src/components/data-table/use-data-table.test.ts`	Tests controlled and default selection.
`packages/core/src/components/data-table/types.ts`	Defines the row-selection API.
`packages/core/src/components/data-table/index.ts`	Exports the selection options type.
`packages/core/src/components/data-table/data-table.tsx`	Updates sorting, animation, and measurement.
`packages/core/src/components/data-table/data-table.test.tsx`	Refactors and expands DataTable tests.
`packages/core/src/components/csv-importer/i18n-labels.ts`	Adds mapping-status labels.
`packages/core/src/components/csv-importer/CsvImporter.tsx`	Improves labels and callback ownership.
`packages/core/src/components/command-palette/command-palette-hook.test.tsx`	Hoists search-source fixtures.
`packages/core/src/components/combobox/combobox.test.tsx`	Hoists timer helpers.
`packages/core/src/components/autocomplete/autocomplete.test.tsx`	Hoists timer helpers.
`packages/core/src/components/attachment/use-attachment.ts`	Tracks owned preview URLs.
`packages/core/src/components/attachment/use-attachment.test.ts`	Tests URL cleanup.
`packages/core/src/components/ai-chat/composer.tsx`	Uses the shared spinner.
`packages/core/src/components/ai-chat/ai-chat.test.tsx`	Consolidates composer fixtures.
`packages/core/src/components/action-panel/ActionPanel.test.tsx`	Hoists the action reader.
`packages/core/src/ai/use-ai-chat.ts`	Removes manual callback memoization.
`examples/vite-app/tsconfig.app.json`	Enables the ES2023 library.
`examples/vite-app/src/pages/data-table/page.tsx`	Refactors loading and toolbar state.
`examples/vite-app/src/mock-products.ts`	Derives loading from result identity.
`examples/vite-app/src/mock-orders.ts`	Derives loading from result identity.
`examples/nextjs-app/src/modules/pages/mock-data.ts`	Derives loading from result identity.
`examples/nextjs-app/src/modules/pages/dropdown-demo.tsx`	Reuses item mapping.
`examples/nextjs-app/src/modules/pages/date-range-rhf-demo.tsx`	Uses `useWatch`.
`examples/nextjs-app/src/app/dashboard/[[...props]]/page.tsx`	Stabilizes the root component.
`.changeset/steady-limes-sort.md`	Records the selection API release.

Review details

Files not reviewed (1)

pnpm-lock.yaml: Generated file

Files reviewed: 54/55 changed files
Comments generated: 5
Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot · 2026-09-14T01:11:13Z

  MoneyCellOptions,
  NumberCellOptions,
  RowAction,
+  RowSelectionOptions,


Fixed in 6caefe3. RowSelectionOptions is now re-exported from the package root.

Copilot · 2026-09-14T01:11:13Z

+    const state = updater(read(tableId, defaults));
+    writeState(tableId, state);
+    cache.set(tableId, {
+      raw: typeof window === "undefined" ? null : JSON.stringify(state),
+      defaults,
+      state,
+    });
+    notify(tableId);


Fixed in 6caefe3. Failed storage writes now retain the prior storage marker so the in-memory update persists.

Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

IzumiSy · 2026-09-14T01:29:46Z

@copilot resolve the merge conflicts in this pull request

…er-state-ownership # Conflicts: # pnpm-lock.yaml Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot · 2026-09-14T01:31:59Z

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in 4ef30a1.

IzumiSy · 2026-09-14T06:44:02Z

@copilot resolve the merge conflicts in this pull request

…er-state-ownership # Conflicts: # examples/nextjs-app/src/app/dashboard/[[...props]]/page.tsx # examples/nextjs-app/src/modules/pages/date-range-rhf-demo.tsx # examples/nextjs-app/src/modules/pages/mock-data.ts # examples/vite-app/src/pages/showcase/data-table/page.tsx # pnpm-lock.yaml # pnpm-workspace.yaml Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot · 2026-09-14T06:48:23Z

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in a262865.

IzumiSy · 2026-09-15T01:24:19Z

@copilot resolve the merge conflicts in this pull request

…er-state-ownership # Conflicts: # pnpm-lock.yaml Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot · 2026-09-15T01:26:42Z

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in 8571d59.

IzumiSy · 2026-09-17T01:59:19Z

@copilot resolve the merge conflicts in this pull request

…er-state-ownership # Conflicts: # packages/core/src/components/sidebar/sidebar.test.tsx # pnpm-lock.yaml Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot · 2026-09-17T02:02:39Z

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in 9752367.

IzumiSy · 2026-09-17T03:00:41Z

/review

github-actions · 2026-09-17T03:01:42Z

✅ Code Review completed successfully!

Generated by Code Review for #525

github-actions

Generated by Code Review for #525 · copilot · gpt54 · 342.4 AIC · ⌖ 6.65 AIC · ⊞ 19.3K
_{Comment /review to run again}

IzumiSy added 6 commits September 11, 2026 15:29

refactor(core): align state ownership with React Compiler

35bdd13

docs(data-table): deprecate legacy selection callback

4eada91

refactor(data-table): encapsulate persistent state cache

c2ec006

docs(data-table): describe persistent state cache

e51f15f

refactor(data-table): inline cache entry type

bf1f1cf

refactor(command-palette): remove display state mirror

320cbf1

Copilot started work on behalf of IzumiSy September 11, 2026 07:02 View session

Merge remote-tracking branch 'origin/main' into refactor/react-compil…

e77ddb5

…er-state-ownership # Conflicts: # packages/core/src/components/data-table/data-table.test.tsx Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

IzumiSy mentioned this pull request Sep 11, 2026

chore(examples,e2e): replace nextjs app with vite showcase #513

Merged

Copilot AI and others added 3 commits September 11, 2026 07:09

fix(core): restore date bridge and sort gating

e5038e0

Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

refactor(ai-chat): reuse shared spinner

a12163e

Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

fix(ai-chat): tighten link cap and pin scroll action

685b465

Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot finished work on behalf of IzumiSy September 11, 2026 07:13

Copilot started work on behalf of IzumiSy September 11, 2026 07:13 View session

test(ai-chat): hoist shared test helpers

3dacba2

Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot finished work on behalf of IzumiSy September 11, 2026 07:16

Fix type error

c7156c9

IzumiSy added 7 commits September 11, 2026 16:31

Refactor data table tests to use renderHook

601e141

Refactor test helpers to use renderHook

c127471

Revert unrelated ai-chat test diffs

3bf43f1

Revert unrelated date-field focus prop diffs

1636175

Revert unrelated ai-chat component diffs

647b939

Use capture-phase date field focus handlers

026bf73

Fix example lint warnings

0b95bcc

IzumiSy marked this pull request as ready for review September 11, 2026 08:14

Copilot started reviewing on behalf of IzumiSy September 14, 2026 00:41 View session

Copilot AI reviewed Sep 14, 2026

View reviewed changes

Copilot started work on behalf of IzumiSy September 14, 2026 01:03 View session

Fix DataTable review feedback

6caefe3

Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot finished work on behalf of IzumiSy September 14, 2026 01:12

Copilot started work on behalf of IzumiSy September 14, 2026 01:30 View session

Merge remote-tracking branch 'origin/main' into refactor/react-compil…

4ef30a1

…er-state-ownership # Conflicts: # pnpm-lock.yaml Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot finished work on behalf of IzumiSy September 14, 2026 01:32

Merge branch 'main' into refactor/react-compiler-state-ownership

3edd85a

Copilot started work on behalf of IzumiSy September 14, 2026 06:44 View session

Copilot finished work on behalf of IzumiSy September 14, 2026 06:48

Copilot started work on behalf of IzumiSy September 15, 2026 01:25 View session

Merge remote-tracking branch 'origin/main' into refactor/react-compil…

8571d59

…er-state-ownership # Conflicts: # pnpm-lock.yaml Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot finished work on behalf of IzumiSy September 15, 2026 01:27

Merge branch 'main' into refactor/react-compiler-state-ownership

2181ba5

Copilot started work on behalf of IzumiSy September 17, 2026 01:59 View session

Merge remote-tracking branch 'origin/main' into refactor/react-compil…

9752367

…er-state-ownership # Conflicts: # packages/core/src/components/sidebar/sidebar.test.tsx # pnpm-lock.yaml Co-authored-by: IzumiSy <982850+IzumiSy@users.noreply.github.com>

Copilot finished work on behalf of IzumiSy September 17, 2026 02:03

github-actions Bot reviewed Sep 17, 2026

View reviewed changes

Uh oh!

Conversation

IzumiSy commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Design Decision

Make reactive state explicit

Limit refs and effects to imperative boundaries

Preserve public behavior during local migrations

Keep the lint configuration authoritative

Summary

Uh oh!

IzumiSy commented Sep 11, 2026

Uh oh!

IzumiSy commented Sep 11, 2026

Uh oh!

Copilot AI commented Sep 11, 2026

Uh oh!

Copilot AI commented Sep 11, 2026

Uh oh!

github-actions Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Metrics Report

Code coverage of files in pull request scope (85.4% → 85.3%, patch 94.3%)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Files not reviewed (1)

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

IzumiSy commented Sep 14, 2026

Uh oh!

Copilot AI commented Sep 14, 2026

Uh oh!

IzumiSy commented Sep 14, 2026

Uh oh!

Copilot AI commented Sep 14, 2026

Uh oh!

IzumiSy commented Sep 15, 2026

Uh oh!

Copilot AI commented Sep 15, 2026

Uh oh!

IzumiSy commented Sep 17, 2026

Uh oh!

Copilot AI commented Sep 17, 2026

Uh oh!

IzumiSy commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

IzumiSy commented Sep 11, 2026 •

edited

Loading

github-actions Bot commented Sep 11, 2026 •

edited

Loading

github-actions Bot commented Sep 17, 2026 •

edited

Loading