feat(send): improve Lightning send failure recovery - #652
Open
pwltr wants to merge 1 commit into
Open
Conversation
pwltr
force-pushed
the
feat/reset-routing
branch
from
August 5, 2026 12:52
896e0dd to
e9c58c5
Compare
pwltr
marked this pull request as ready for review
August 5, 2026 13:01
Greptile SummaryThe PR moves Lightning failures into a dedicated retry flow, resets routing caches before retrying, and adds localized failure messages.
Confidence Score: 4/5The PR is not yet safe to merge because a failed Lightning stop can leave the wallet permanently stuck in the stopping lifecycle state. The recovery path calls Files Needing Attention: Bitkit/Views/Wallets/Send/SendFailure.swift; Bitkit/ViewModels/WalletViewModel.swift
|
| Filename | Overview |
|---|---|
| Bitkit/Views/Wallets/Send/SendFailure.swift | Implements cache-reset and node-restart recovery, but a stop failure can leave the lifecycle stuck in .stopping. |
| Bitkit/ViewModels/WalletViewModel.swift | Adds routing-cache reset and freshness polling while retaining a lifecycle state that the retry restart cannot recover. |
| Bitkit/Views/Wallets/Send/SendSheet.swift | Adds retry-route metadata and restores the corresponding confirmation flow. |
| Bitkit/Extensions/PaymentFailureReason+UserMessage.swift | Centralizes generic and send-specific localized payment-failure mappings. |
Reviews (2): Last reviewed commit: "feat(send): improve Lightning send failu..." | Re-trigger Greptile
pwltr
force-pushed
the
feat/reset-routing
branch
2 times, most recently
from
August 6, 2026 11:08
0605e65 to
0949bb0
Compare
pwltr
marked this pull request as draft
August 6, 2026 12:38
pwltr
force-pushed
the
feat/reset-routing
branch
from
August 6, 2026 13:58
0949bb0 to
68877e8
Compare
pwltr
marked this pull request as ready for review
August 6, 2026 15:12
pwltr
force-pushed
the
feat/reset-routing
branch
from
August 7, 2026 10:53
68877e8 to
2261ea2
Compare
Contributor
Author
|
Failing e2e seems unrelated, ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PaymentFailureReasonuser-message mapping intoPaymentFailureReason+UserMessage.swiftwith generic and send-specific contexts.Closes #483
Simulator.Screen.Recording.-.iPhone.17.-.2026-08-04.at.19.07.07.mov