Skip the visual diff against stable 3084 - #768
Closed
cyberb wants to merge 1 commit into
Closed
Conversation
The nightly artifact prune on the CI host deleted platform/3084-*, which
is the build FindLatestBuild("stable") resolves to, so ci-diff downloads
an empty tree and every branch build fails with "no screenshots were
compared". Nothing is wrong with the screenshots; the baseline no longer
exists.
3076 was the previous occurrence of the same thing. The constant only
matches when it equals the current latest stable, so it went inert the
moment stable moved to 3084 and has to be hand-bumped each time.
This unblocks branch builds until the baseline regenerates on the next
stable push. It is a stopgap: ci-diff still cannot tell a pruned
baseline from a screenshot regression, and until DownloadBuild fails on
a missing build directory this will keep costing an investigation each
time it recurs.
Member
Author
|
Folding this into #767 instead so that branch goes green directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line stopgap to unblock platform branch builds.
Why
FindLatestBuild("stable")resolves to build 3084 (2026-08-19). The nightly artifact prune on the CI host deletedplatform/3084-*, soci-diffdownloads an empty tree and every branch build fails:Nothing is wrong with the screenshots — the baseline no longer exists. This currently fails every platform PR, not just one.
3076was the previous occurrence of the same thing. The constant only takes effect when it equals the current latest stable, so it went inert the moment stable moved to 3084.What this does not fix
visual-diff/cmd/app.go:54—DownloadBuildreturnsnilfor a build directory that does not exist, so a pruned baseline is indistinguishable from a screenshot regression until you read the log.Both are worth a follow-up; this is the stopgap.
The baseline regenerates on the next stable push. Going forward it is protected from pruning by the artifact cleaner now running on the CI host, which keeps the last green stable per app regardless of age.
Validated with
drone jsonnet+drone lint; generated step readsci-diff artifact/playwright 3084.