Conversation
|
Install the latest version of pnx https://pkg.svelte.dev/sv/c/da264b677df545fd86185d85fe32ffd0d40e891b createOpen in |
🦋 Changeset detectedLatest commit: da264b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jycouet
marked this pull request as draft
September 20, 2026 12:51
Each add-on declares the values its options produce (`AddonOptions<Values>`) and exports that type; `officialAddons` wires them to ids, so the compiler - not a snapshot test - keeps types and questions in sync. Consumers get `OfficialAddonOptions`, add-on authors get the same pattern for their own add-ons.
jycouet
force-pushed
the
feat-export-addon-option-types
branch
from
September 20, 2026 12:52
b2b5477 to
c7739fc
Compare
`testing.ts` re-exports most of the root entry, so its snapshot repeated those declarations verbatim. They are now replaced by a single pointer comment to `api-surface.md`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1333: each add-on declares and exports the values its options produce.
const options: AddonOptions<VitestOptions> = defineAddonOptions()...- the compiler checks questions against the declared values, andofficialAddonsjust wires each exported type to an id, so nothing can drift. Consumers getOfficialAddonOptions, add-on authors get the same pattern (docs added).api-surface.md335 → 391 lines,oxcstays.