Conversation
`testing.ts` re-exports most of the root entry, so its snapshot repeated those declarations verbatim. They are now replaced by a single pointer comment to `api-surface.md`.
Drops the `Addon<any>` annotation on `officialAddons` so every add-on keeps its real option types. `oxc` cannot emit declarations for inferred objects (isolatedDeclarations), so the `sv` DTS builds switch to the `tsgo` generator, which infers them - at the cost of ~1200 extra lines of option literals in the public `.d.ts`.
🦋 Changeset detectedLatest commit: 0fcf5b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Install the latest version of pnx https://pkg.svelte.dev/sv/c/0fcf5b55f63d28f80c815d0f3c9e6c559d2ce796 createOpen in |
jycouet
marked this pull request as draft
September 20, 2026 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1333: fully inferred instead of hand-written.
Drops the
Addon<any>table and switches thesvDTS builds to thetsgogenerator (oxccan't infer under isolatedDeclarations). No types to maintain, butapi-surface.mdgrows 335 → 1561 lines of question literals and the publishedengine.d.mts15 kB → 42 kB.First commit is independent: api-surface snapshots now dedupe declarations shared with another package's surface (
api-surface-testing.md260 → 81 lines).