433 doctrine extension listener - #249
Merged
Merged
Conversation
DoctrineExtensionListener was never registered in config/services.php and has never been wired up in this bundle's history. Remove the listener, the gedmo/doctrine-extensions dependency, and the stale "Unused code" note that documented it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR removes the unused DoctrineExtensionListener, drops the no-longer-needed gedmo/doctrine-extensions dependency, and updates the documentation to eliminate the obsolete unused-code guidance. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
tijsverkoyen
approved these changes
Sep 16, 2026
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="composer.json" line_range="25" />
<code_context>
"prefer-stable": true,
"require": {
"php": "^8.5",
- "gedmo/doctrine-extensions": "^3.17",
"knplabs/knp-menu-bundle": "^3.4",
"symfony/form": "^8.0",
</code_context>
<issue_to_address>
**nitpick:** The deleted `DoctrineExtensionListener` is still listed in `phpstan.dist.neon` under `ignoreErrors`, leaving static-analysis configuration pointing at a file that no longer exists. Remove that stale path along with the listener.
**Triggers:** When PHPStan configuration is reviewed or future errors are added for the deleted path.
**Suggested fix:** Delete the `src/EventListener/DoctrineExtensionListener.php` entry from `phpstan.dist.neon`.
</issue_to_address>Sourcery assessment
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AC: https://next-app.activecollab.com/108877/my-work?modal=Task-259199-533
Removes the dead DoctrineExtensionListener (unused Gedmo Blameable/Loggable wiring),
drops the gedmo/doctrine-extensions dependency, and removes the stale "Unused code"
documentation note that described it.
Summary by Sourcery
Remove unused Doctrine extension integration and its associated dependency and documentation.
Enhancements:
Build:
Documentation: