Skip to content

433 doctrine extension listener - #249

Merged
jonasdekeukelaere merged 2 commits into
masterfrom
433-doctrine-extension-listener
Sep 16, 2026
Merged

jonasdekeukelaere merged 2 commits into
masterfrom
433-doctrine-extension-listener

Conversation

@jonasdekeukelaere

@jonasdekeukelaere jonasdekeukelaere commented Sep 16, 2026

Copy link
Copy Markdown
Member

AC: https://next-app.activecollab.com/108877/my-work?modal=Task-259199-533

Removes the dead DoctrineExtensionListener (unused Gedmo Blameable/Loggable wiring),
drops the gedmo/doctrine-extensions dependency, and removes the stale "Unused code"
documentation note that described it.

Summary by Sourcery

Remove unused Doctrine extension integration and its associated dependency and documentation.

Enhancements:

  • Remove the unused Doctrine extension listener and its obsolete Gedmo integration.

Build:

  • Remove the unused gedmo/doctrine-extensions Composer dependency.

Documentation:

  • Remove the stale documentation describing the unused Doctrine extension listener.

DoctrineExtensionListener was never registered in config/services.php
and has never been wired up in this bundle's history. Remove the
listener, the gedmo/doctrine-extensions dependency, and the stale
"Unused code" note that documented it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR removes the unused DoctrineExtensionListener, drops the no-longer-needed gedmo/doctrine-extensions dependency, and updates the documentation to eliminate the obsolete unused-code guidance.

File-Level Changes

Change Details Files
Remove obsolete Doctrine extension listener and its unused dependency.
  • Delete the unregistered Gedmo Blameable/Loggable event listener.
  • Remove gedmo/doctrine-extensions from runtime dependencies.
src/EventListener/DoctrineExtensionListener.php
composer.json
Clean up documentation describing the removed dead code.
  • Remove the stale documentation note about manually registering the listener and enabling Gedmo tracking.
docs/index.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="composer.json" line_range="25" />
<code_context>
   "prefer-stable": true,
   "require": {
     "php": "^8.5",
-    "gedmo/doctrine-extensions": "^3.17",
     "knplabs/knp-menu-bundle": "^3.4",
     "symfony/form": "^8.0",
</code_context>
<issue_to_address>
**nitpick:** The deleted `DoctrineExtensionListener` is still listed in `phpstan.dist.neon` under `ignoreErrors`, leaving static-analysis configuration pointing at a file that no longer exists. Remove that stale path along with the listener.

**Triggers:** When PHPStan configuration is reviewed or future errors are added for the deleted path.

**Suggested fix:** Delete the `src/EventListener/DoctrineExtensionListener.php` entry from `phpstan.dist.neon`.
</issue_to_address>

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread composer.json
@jonasdekeukelaere
jonasdekeukelaere merged commit 4fbf5d6 into master Sep 16, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants