Skip to content

Publish the tarball npm packed, not a git URL #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suffro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Publish the tarball npm packed, not a git URL #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/publish-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ jobs:
# The glob is resolved and counted rather than passed straight to npm: `npm publish` given two
# paths would publish the first and say nothing about the second, and given none would fall
# back to publishing the current directory — which here is an empty runner, not the package.
#
# The `./` below is load-bearing. npm reads an argument that contains a slash but does not
# start with `./`, `/` or `../` as a hosted git shorthand, so `dist/scrollcase-1.1.1.tgz`
# became a request to clone `ssh://git@github.com/dist/scrollcase-1.1.1.tgz.git`. That is how
# both releases this workflow has seen failed, and went out by hand instead.
- name: Publish
shell: bash
run: |
Expand All @@ -96,4 +101,4 @@ jobs:
printf ' %s\n' "${tarballs[@]}" >&2
exit 1
fi
npm publish "${tarballs[0]}"
npm publish "./${tarballs[0]}"
Loading