Skip to content

fix(spark)!: derive the dialect from core's model and the runtime's functions - #1133

Open
nielspardon wants to merge 1 commit into
substrait-io:mainfrom
nielspardon:fix/dialect-generator-derived-model
Open

fix(spark)!: derive the dialect from core's model and the runtime's functions#1133
nielspardon wants to merge 1 commit into
substrait-io:mainfrom
nielspardon:fix/dialect-generator-derived-model

Conversation

@nielspardon

@nielspardon nielspardon commented Aug 19, 2026

Copy link
Copy Markdown
Member

The generator restated things it could derive, and each restatement was a way for the published spark_dialect.yaml to drift without a test failing.

Aggregate and window functions came from the collection merged with spark.yml while the runtime converters bind against the standard extensions only, so an aggregate added to spark.yml would be advertised and then fail with "Unable to find binding for call". All three sections now come from the collections SparkExtension hands the runtime, passed to the generator explicitly.

The dependencies block was an unsorted Map, so its order was an artifact of one Scala version's String hashing; it is now built as a SortedMap from the URNs the emitted functions actually reference. A hand-maintained URN-to-alias map returned "" for an unmapped URN, emitting a source that dangled against dependencies while still validating against the schema, which declares source as a plain string; the alias is now derived from the URN's last segment, and two URNs deriving the same alias fail rather than one silently displacing the other.

The dialect is emitted through io.substrait.dialect.Dialect rather than a parallel set of Scala case classes that typed enums as String, so the generator can no longer express a dialect core would reject, and a dialect-schema field core gains no longer has to be added a second time before Spark can express it.

The published file is unchanged apart from key order: core's field order, dependencies sorted, and max_precision ahead of system_metadata. Comparing the parsed models cannot catch an ordering change, since Dialect.dependencies is a Map, so the published text is now compared as text — which in turn needs the file declared as a Test input so that editing it invalidates the tests.

Worth knowing while reviewing: the aggregate/window fix has no test that can fail today. With spark.yml declaring no aggregate or window function, the merged collection and the standard collection are indistinguishable, so reverting that wiring alone breaks nothing observable. The guard checks the advertised aggregates and windows against DefaultExtensionCatalog.DEFAULT_COLLECTION directly rather than against what the generator was handed, so it arms the moment spark.yml gains one — the same moment the bug would go live. dependencies is still derived from function URNs only, so a USER_DEFINED supported type would need its own alias folded in; the dangling-source test covers type sources too, so that would fail rather than ship.

Two unreachable branches in the function probe went with the rewrite, one of them a println aimed at the same System.out that main writes the dialect to.

Closes #1087

BREAKING CHANGE: io.substrait.spark.utils.Dialect, SupportedType, TypeMetadata, FunctionMetadata and SupportedFunction are removed; the dialect is modelled by io.substrait.dialect.Dialect and friends. DialectGenerator.generate() returns io.substrait.dialect.Dialect, and the DialectGenerator class now takes the scalar, aggregate and window function collections it generates from.

@nielspardon
nielspardon marked this pull request as ready for review August 19, 2026 11:28
@nielspardon
nielspardon marked this pull request as draft August 19, 2026 11:37
@nielspardon
nielspardon force-pushed the fix/dialect-generator-derived-model branch from f7dd4b9 to cb4ab38 Compare August 19, 2026 12:01
@nielspardon
nielspardon marked this pull request as ready for review August 19, 2026 13:04

@alexandrefimov alexandrefimov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read this against main at 961f83e, which now includes #1128 — that is where the one thing I would act on comes from.

max_precision for the three temporal types is the last restatement left in supportedTypes, and it is the kind this PR is about. Some(9) says what Util.MICROSECOND_PRECISION and the conversion guard already say, and they now say 6: #1128 pinned the type conversions at exactly microseconds and fed the generator from that constant. Rebasing conflicts in DialectGenerator.scala and spark_dialect.yaml, and resolving either in this branch's favour puts the 9 back — I tried it, and ./gradlew dialect regenerates the file with max_precision: 9 in three places, which fails core's SparkDialectParseTest.parsesPrecisionTypes with expected: <6> but was: <9>. CI catches it, so this is a heads-up for the rebase rather than a defect in what is here.

Separately, I checked the premise of the aggregate/window fix, since you note it has no test that can fail today. It holds: on main the generator reads COLLECTION.aggregateFunctions() where COLLECTION = EXTENSION_COLLECTION.merge(SparkImpls), while toAggregateFunction and toWindowFunction are built from EXTENSION_COLLECTION alone. So the advertised set really is the wider one, and the scalar side was already consistent because the generator used SparkScalarFunctions, which is the merged one on both sides.

Comment thread spark/src/main/scala/io/substrait/spark/utils/DialectGenerator.scala Outdated
@nielspardon
nielspardon force-pushed the fix/dialect-generator-derived-model branch from cb4ab38 to 3207810 Compare August 19, 2026 15:19
@nielspardon

Copy link
Copy Markdown
Member Author

Rebased onto 961f83e and resolved both conflicts in #1128's favour: supportedTypes reads Util.MICROSECOND_PRECISION and carries your comment, so ./gradlew dialect emits max_precision: 6 in all three places. The regenerated file's content now matches main's exactly — the only difference left is the key ordering this PR introduces (core's field order, dependencies sorted, max_precision ahead of system_metadata). Your suggestion applies as-is apart from scalafmt reflowing two of the three calls, which are over 100 columns on one line.

Thanks for checking the aggregate/window premise independently — that was the part I could not pin with a test.

@nielspardon
nielspardon force-pushed the fix/dialect-generator-derived-model branch 2 times, most recently from c58455a to fca26d8 Compare August 20, 2026 05:27
…unctions

The generator restated things it could derive, and each restatement was a
way for the published spark_dialect.yaml to drift without a test failing.

Aggregate and window functions came from the collection merged with
spark.yml while the runtime converters bind against the standard
extensions only, so an aggregate added to spark.yml would be advertised
and then fail with "Unable to find binding for call". All three sections
now come from the collections SparkExtension hands the runtime, passed to
the generator explicitly.

The dependencies block was an unsorted Map, so its order was an artifact
of one Scala version's String hashing; it is now built as a SortedMap
from the URNs the emitted functions actually reference. A hand-maintained
URN-to-alias map returned "" for an unmapped URN, emitting a source that
dangled against dependencies while still validating against the schema,
which declares source as a plain string; the alias is now derived from
the URN's last segment.

The dialect is emitted through io.substrait.dialect.Dialect rather than a
parallel set of Scala case classes that typed enums as String, so the
generator can no longer express a dialect core would reject.

The published file is unchanged apart from key order: core's field order,
dependencies sorted, and max_precision ahead of system_metadata. An
ordering change cannot be caught by comparing the parsed models, since
Dialect.dependencies is a Map, so the published text is now compared as
text.

Closes substrait-io#1087

BREAKING CHANGE: io.substrait.spark.utils.Dialect, SupportedType,
TypeMetadata, FunctionMetadata and SupportedFunction are removed; the
dialect is modelled by io.substrait.dialect.Dialect and friends.
DialectGenerator.generate() returns io.substrait.dialect.Dialect, and the
DialectGenerator class now takes the scalar, aggregate and window
function collections it generates from.
@nielspardon
nielspardon force-pushed the fix/dialect-generator-derived-model branch from fca26d8 to 666fe3d Compare August 20, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DialectGenerator: hand-maintained URN map, non-deterministic dependencies order, and a parallel dialect model

2 participants