Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: passed
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
gunjjoshi
commented
Sep 20, 2026
Comment on lines
+70
to
+74
| // cos( 2π/3 ): | ||
| var TAUR = -0.5; | ||
|
|
||
| // sin( 2π/3 ): | ||
| var TAUI = 0.8660253882408142; |
Member
Author
There was a problem hiding this comment.
Converted the double-precision values present here to float32:
In [15]: var f32 = require( '@stdlib/number/float64/base/to-float32' );
In [16]: f32(-0.5)
Out[16]: -0.5
In [17]: f32(0.866025403784439)
Out[17]: 0.8660253882408142
gunjjoshi
commented
Sep 20, 2026
Comment on lines
+70
to
+80
| // cos( 2π/5 ): | ||
| var TR11 = 0.30901700258255005; | ||
|
|
||
| // sin( 2π/5 ): | ||
| var TI11 = 0.9510565400123596; | ||
|
|
||
| // cos( 4π/5 ): | ||
| var TR12 = -0.80901700258255; | ||
|
|
||
| // sin( 4π/5 ): | ||
| var TI12 = 0.5877852439880371; |
Member
Author
There was a problem hiding this comment.
In [18]: f32(0.309016994374947)
Out[18]: 0.30901700258255005
In [19]: f32(0.951056516295154)
Out[19]: 0.9510565400123596
In [20]: f32(-0.809016994374947)
Out[20]: -0.80901700258255
In [21]: f32(0.587785252292473)
Out[21]: 0.5877852439880371
gunjjoshi
commented
Sep 20, 2026
Comment on lines
+109
to
+110
| fview = new Uint32Array( w.buffer, w.byteOffset, w.length ); | ||
| rfftf1( N, r, strideR, offsetR, w, strideW, offsetW, w, strideW, offsetT, fview, strideW, offsetF ); // eslint-disable-line max-len |
Member
Author
There was a problem hiding this comment.
Passing the factorization region of the workspace as a Uint32Array view here.
gunjjoshi
commented
Sep 20, 2026
Comment on lines
+126
to
+128
| l1 = floor( l2 / factor ); | ||
|
|
||
| ido = floor( N / l2 ); |
Member
Author
There was a problem hiding this comment.
Using floor here instead of floorf, since the operands are integers only.
gunjjoshi
commented
Sep 20, 2026
| # @param {(string|void)} fPIC - flag indicating whether to generate position independent code | ||
| #/ | ||
| $(c_targets): %.out: %.c | ||
| $(QUIET) $(CC) $(CFLAGS) $(fPIC) -o $@ $(FFTPACK_SRC) $< -lm |
Member
Author
There was a problem hiding this comment.
Not having the -DFFTPACK_DOUBLE_PRECISION flag here (which is present here), since this is not a double-precision package.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
gunjjoshi
commented
Sep 20, 2026
| input = large.input; | ||
| expected = large.expected; | ||
|
|
||
| ulps = 1; |
Member
Author
There was a problem hiding this comment.
Here and in all other tests in this package, we require only 1 ulp, unlike that in generic variant of rfftf, where we required around 800.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves stdlib-js/metr-issue-tracker#1334.
Description
This pull request:
fft/base/fftpack/float32/rfftf, which will be single-precision floating-point equivalent forfft/base/fftpack/generic/rfftf.Related Issues
This pull request has the following related issues:
fft/base/fftpack/float32/rfftfmetr-issue-tracker#1334.Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Used Claude code review the implementation.
@stdlib-js/reviewers