Skip to content

style: add spaces - #15370

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-09-20
Sep 21, 2026
Merged

kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-09-20

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • provides follow-up fixes for commits merged to develop between 2026-09-19T16:10:17-07:00 (99219fa68) and 2026-09-19T16:16:55-07:00 (f273c33c8).

Fixes by package:

  • math/base/special/roundnf: Fixes an unspaced array index introduced in 99219fa: expected[i] in roundnf/test/test.js:277 and test.native.js:270 should be expected[ i ], per the spacing rule in docs/style-guides/javascript/README.md:177 and consistent with every other assertion added in that migration.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation performed on the 24-hour commit window (7 commits):

  • Checked: stdlib JavaScript style-guide compliance (compared against untouched reference packages already using isAlmostSameValue-based assertions), bug scan of the diff (argument order, dangling references to removed abs/EPS/ulpdiff requires, sibling test.js/test.native.js divergence, always-passing assertions), and execution of the migrated assertions against the actual test fixtures (all pass, including the tightened ULP tolerances). The 'float32''float16' documentation changes were verified against the float16-aware ndarray/min-dtype implementation (minDataType( 3.141592653589793 ) returns 'float16').
  • Deliberately excluded: tolerance-value choices (0 vs 1 ULP, narrowing from 30.0 * EPS and 2 ULP — deliberate convention standardization), require-statement ordering and inline comment style (both orderings/styles coexist in untouched reference packages), and anything requiring interpretation or changes outside the diff window.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of a scheduled automated review of commits merged to develop in the last 24 hours. Findings were cross-validated by multiple independent review passes before inclusion.


🤖 Generated with Claude Code

https://claude.ai/code/session_016t3qsVY4Zt14xaKMNgB4tX


Generated by Claude Code

…roundnf`

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016t3qsVY4Zt14xaKMNgB4tX
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Sep 20, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/roundnf $\\color{red}271/273$
$\\color{green}+99.27\\%$
$\\color{red}22/23$
$\\color{green}+95.65\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{red}271/273$
$\\color{green}+99.27\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review September 21, 2026 07:22
@kgryte
kgryte requested a review from a team September 21, 2026 07:22
@kgryte kgryte changed the title style: add missing spaces around array indices in math/base/special/roundnf style: add spaces Sep 21, 2026
@kgryte
kgryte merged commit 48f3eda into develop Sep 21, 2026
34 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-09-20 branch September 21, 2026 07:23
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants