Skip to content

test: migrate math/base/special/asinh to ULP-based testing - #15363

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
DivyanshuVortex:migrate-asinh-ulp
Sep 21, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
DivyanshuVortex:migrate-asinh-ulp

Conversation

@DivyanshuVortex

@DivyanshuVortex DivyanshuVortex commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request finishes the ULP-based testing migration for math/base/special/asinh. Specifically, it:

  • Removes old relative tolerance dependencies from test.native.js
  • Updates assertions in test.native.js to use ULP-based testing (isAlmostSameValue)

(Note: PR #11654 previously migrated the JavaScript tests for asinh to ULP-based testing, but inadvertently left out the native bindings tests. This PR completes the migration by updating the forgotten native test file.)

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@DivyanshuVortex
DivyanshuVortex requested a review from a team September 20, 2026 06:16
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Sep 20, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 20, 2026
@DivyanshuVortex
DivyanshuVortex marked this pull request as draft September 20, 2026 06:17
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 20, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/asinh $\\color{green}235/235$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}235/235$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Sep 20, 2026
@DivyanshuVortex DivyanshuVortex changed the title test: migrate math/base/special/asinh to ULP-based testing test: migrate math/base/special/asinh to ULP-based testing Sep 20, 2026
@DivyanshuVortex
DivyanshuVortex marked this pull request as ready for review September 20, 2026 06:42
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 20, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 and removed Needs Review A pull request which needs code review. labels Sep 21, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit 95fd0e2 into stdlib-js:develop Sep 21, 2026
139 of 140 checks passed
@DivyanshuVortex

Copy link
Copy Markdown
Contributor Author

Thnx

@DivyanshuVortex
DivyanshuVortex deleted the migrate-asinh-ulp branch September 21, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants