chore: follow-up fixes for commits merged to develop (2026-08-04/05) - #13949
Open
Planeshifter wants to merge 2 commits into
Open
chore: follow-up fixes for commits merged to develop (2026-08-04/05)#13949Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
…uint64` The private `getUint64` helper is a plain function, not a constructor, and is invoked without `new` at every other call site. Also updates the `entries` JSDoc example return annotations to use `<Uint64>`, matching the README, REPL docs, and TypeScript declaration examples. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rAgMTvhZQG45E6NcnoguQ
Corrects "where as" to "whereas" in the README notes section, matching the identical sentence in the REPL docs, TypeScript declarations, and source JSDoc. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rAgMTvhZQG45E6NcnoguQ
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-08-04T23:40:56-07:00 (879f1c8) and 2026-08-05T01:39:52-07:00 (b9396e3).This pull request:
array/uint64getUint64is a plain function, not a constructor — drop the straynewin theentriesiterator added in b5ff3b6 (lib/node_modules/@stdlib/array/uint64/lib/main.js:676); every other call site already invokes it withoutnew.array/uint64/lib/main.js(b5ff3b6), the newentriesJSDoc examples annotate returns as<Uint>[ 1n ]etc. — should be<Uint64>, matching README.md, docs/repl.txt, and docs/types/index.d.ts. Fixed lines 624-630 to<Uint64>.ml/base/loss/float64/hinge-gradienthinge-gradientREADME (b9396e3): repl.txt, the .d.ts, and the source JSDoc all spell it "whereas" in the same sentence —lib/node_modules/@stdlib/ml/base/loss/float64/hinge-gradient/README.md:102just missed it.Related Issues
No.
Questions
No.
Other
Validation. All 15 commits merged to
developin the 24-hour window were reviewed by independent passes for (1) stdlib style-guide compliance (docs/style-guides), assessed against established reference packages of similar complexity (math/base/special/exp,ml/base/loss/float64/squared-hinge-gradient,array/bool), and (2) bugs in the introduced code (logic, constants, C sources, CI shell changes). Only findings corroborated by multiple independent passes and re-verified against the diff were retained. Deliberately excluded: anything requiring interpretation or judgment calls, subjective style preferences not mandated by the style guides, and anything whose validation would require touching code outside the window's diff. Notably verified clean:math/base/special/expfconstants/polynomial coefficients,ml/base/loss/float64/hinge-gradientJS/C/fixture logic, theuniq→sort -uCI dedup fix, and the ULP-based test migrations.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a scheduled automated review of commits recently merged to
develop. Findings were generated by multiple independent review passes, cross-checked, and re-verified against the diffs before the fixes were applied.🤖 Generated with Claude Code
https://claude.ai/code/session_019rAgMTvhZQG45E6NcnoguQ
Generated by Claude Code