Skip to content

chore: follow-up fixes for commits merged to develop (2026-08-04/05) - #13949

Open
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-08-05
Open

chore: follow-up fixes for commits merged to develop (2026-08-04/05)#13949
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-08-05

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-08-04T23:40:56-07:00 (879f1c8) and 2026-08-05T01:39:52-07:00 (b9396e3).

This pull request:

  • array/uint64
    • getUint64 is a plain function, not a constructor — drop the stray new in the entries iterator added in b5ff3b6 (lib/node_modules/@stdlib/array/uint64/lib/main.js:676); every other call site already invokes it without new.
    • In array/uint64/lib/main.js (b5ff3b6), the new entries JSDoc examples annotate returns as <Uint>[ 1n ] etc. — should be <Uint64>, matching README.md, docs/repl.txt, and docs/types/index.d.ts. Fixed lines 624-630 to <Uint64>.
  • ml/base/loss/float64/hinge-gradient
    • Fix "where as" typo in hinge-gradient README (b9396e3): repl.txt, the .d.ts, and the source JSDoc all spell it "whereas" in the same sentence — lib/node_modules/@stdlib/ml/base/loss/float64/hinge-gradient/README.md:102 just missed it.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 15 commits merged to develop in the 24-hour window were reviewed by independent passes for (1) stdlib style-guide compliance (docs/style-guides), assessed against established reference packages of similar complexity (math/base/special/exp, ml/base/loss/float64/squared-hinge-gradient, array/bool), and (2) bugs in the introduced code (logic, constants, C sources, CI shell changes). Only findings corroborated by multiple independent passes and re-verified against the diff were retained. Deliberately excluded: anything requiring interpretation or judgment calls, subjective style preferences not mandated by the style guides, and anything whose validation would require touching code outside the window's diff. Notably verified clean: math/base/special/expf constants/polynomial coefficients, ml/base/loss/float64/hinge-gradient JS/C/fixture logic, the uniqsort -u CI dedup fix, and the ULP-based test migrations.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of a scheduled automated review of commits recently merged to develop. Findings were generated by multiple independent review passes, cross-checked, and re-verified against the diffs before the fixes were applied.


🤖 Generated with Claude Code

https://claude.ai/code/session_019rAgMTvhZQG45E6NcnoguQ


Generated by Claude Code

claude added 2 commits August 5, 2026 12:39
…uint64`

The private `getUint64` helper is a plain function, not a constructor,
and is invoked without `new` at every other call site. Also updates the
`entries` JSDoc example return annotations to use `<Uint64>`, matching
the README, REPL docs, and TypeScript declaration examples.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019rAgMTvhZQG45E6NcnoguQ
Corrects "where as" to "whereas" in the README notes section, matching
the identical sentence in the REPL docs, TypeScript declarations, and
source JSDoc.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019rAgMTvhZQG45E6NcnoguQ
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/uint64 $\\color{red}1294/1299$
$\\color{green}+99.62\\%$
$\\color{red}196/200$
$\\color{green}+98.00\\%$
$\\color{green}20/20$
$\\color{green}+100.00\\%$
$\\color{red}1294/1299$
$\\color{green}+99.62\\%$
ml/base/loss/float64/hinge-gradient $\\color{green}206/206$
$\\color{green}+100.00\\%$
$\\color{green}14/14$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}206/206$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review August 5, 2026 13:30
@Planeshifter
Planeshifter requested review from a team and kgryte August 5, 2026 13:30
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants