-
-
Notifications
You must be signed in to change notification settings - Fork 39
Export srs_diff_est() #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vinniott
wants to merge
22
commits into
stan-dev:master
Choose a base branch
from
vinniott:export-srs-diff-est
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a2db120
set up documentation structure
vinniott 5fe5c34
srs_diff_est.Rd matches .R documentation
vinniott 6e8862d
added documentation
vinniott bf6b2b3
added @seealso at loo_subsample()
vinniott 6f485ac
added reference Cochran (1977)
vinniott 67275cf
removed oudated @return duplicate
vinniott caa9ef6
corrected .R formulas to render in .Rd
vinniott ddf1d87
removed example placeholder
vinniott 9699240
updated .Rd to match .R
vinniott c0a5447
Update NEWS.md
vinniott 94fb757
added @examples placeholder
vinniott 535f464
added generation of wine example
vinniott 30cc34e
added full example
vinniott bdbf2fb
Clarified function description
vinniott fee2789
\dontrun{wine example}
vinniott cfe17bf
\dont{example} fully functional in console
vinniott 2edc4b9
Merge branch 'master' into export-srs-diff-est
VisruthSK eda31a9
Edit example comment
avehtari 8d6c062
Update loo_subsample.R
VisruthSK 0d3107d
Merge branch 'master' into export-srs-diff-est
florence-bockting b30eb45
Apply batched suggestions from code review
avehtari 1794152
Merge branch 'master' into export-srs-diff-est
VisruthSK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avehtari or @MansMeg please correct me if I'm wrong, but for the documentation of the returned values, wouldn't this be more correct?
y_hat: estimated total \eqn{\sum_i y_i}, equivalently \eqn{n E[y]}v_y_hat: estimated sampling variance ofy_hatdue to subsamplinghat_v_y: estimated variance component for the total \eqn{\sum_i y_i} used to compute the standard errorsqrt(hat_v_y)In particular, the current
@returndoc says the estimatey_hatis the estimated mean of \eqn{y} but I thought it was the estimate of \eqn{n E[y]}? Or am I mistaken?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MansMeg are you able to comment on this? I think @avehtari is traveling. I'm not entirely sure if my suggested changes are correct or if we should leave the current text. Thanks!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a mismatch between the paper and the code in whether including n or not, but the code has a comment
which means you are correct and I like your suggestion