`crps.numeric` does not pass `permutations` correctly to `crps.matrix`

[thanasibakis]

Minimal reproducible example:

paste("loo version:", packageVersion("loo"), "\n") |> cat()

N = 1000000

cat("crps.numeric:\n")
system.time(
  loo:::crps.numeric(1:3, 4:6, 5, permutations=N)
)

cat("crps.matrix:\n")
system.time(
  loo:::crps.matrix(as.matrix(1:3), as.matrix(4:6), 5, permutations=N)
)

Output on my machine:

loo version: 2.10.1
crps.numeric:
   user  system elapsed
  0.007   0.002   0.009
crps.matrix:
   user  system elapsed
  6.954   0.033   6.989

I believe the issue is with this line:

loo/R/crps.R

Line 97 in df27ade

crps.matrix(as.matrix(x), as.matrix(x2), y, permutations)

The permutations argument gets absorbed into the ...; I believe it needs to be passed as a named argument.

Also applies to scrps.numeric.

[jgabry]

Thank you! I guess we didn't have a test for this so we didn't catch it before. I just added a test to your PR.